ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Muzafarov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9149) Get rid of logging remaining supplier nodes rebalance time
Date Wed, 07 Nov 2018 14:14:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678268#comment-16678268

Maxim Muzafarov commented on IGNITE-9149:


Thank you for your work! 
I think the changes are almost ready. I've left some comments in your PR.

Please, fix them and set Patch Available status to this issue.

> Get rid of logging remaining supplier nodes rebalance time
> ----------------------------------------------------------
>                 Key: IGNITE-9149
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9149
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Maxim Muzafarov
>            Assignee: PetrovMikhail
>            Priority: Minor
>              Labels: rebalance
> Logging rebalance execution time in section of each supplier node have no sence and provides
no helpfull info for analyzing logs. It also overcomplicates {{GridDhtPartitionDemander}}.
> I'm suggesting remove it by simplifying {{Map<UUID, T2<Long, IgniteDhtDemandedPartitionsMap>>}}
to {{Map<UUID, IgniteDhtDemandedPartitionsMap>}}.
> {code:java}
> /** Remaining. T2: startTime, partitions */
> private final Map<UUID, T2<Long, IgniteDhtDemandedPartitionsMap>> remaining
= new HashMap<>();
> {code}

This message was sent by Atlassian JIRA

View raw message