ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanislav Lukyanov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9005) Eviction policy MBeans change failed LifecycleAwareTest on cache name injectoin
Date Fri, 09 Nov 2018 11:18:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681286#comment-16681286
] 

Stanislav Lukyanov commented on IGNITE-9005:
--------------------------------------------

I've taken a look at my PR and at the issue one more time. The problem is that cache doesn't
properly initalize all of the nested lifecycle aware entities. I think a good solution is
to move initialization outside of the cache itself. Eviction policies are owned by eviction
manager, so let's handle them there.
I can't remember what was the problem with the PR in its current state - probably some test
failures.
I've started a TC run, let's wait for the result. I guess if the tests pass we might ask for
a review and merge.

> Eviction policy MBeans change failed LifecycleAwareTest on cache name injectoin
> -------------------------------------------------------------------------------
>
>                 Key: IGNITE-9005
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9005
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Dmitriy Pavlov
>            Assignee: Stanislav Lukyanov
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.8
>
>
> http://apache-ignite-developers.2346864.n4.nabble.com/MTCGA-new-failures-in-builds-1485687-needs-to-be-handled-td32531.html
> New test failure detected https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=7246907407546697403&branch=%3Cdefault%3E&tab=testDetails
> after merging 
> IGNITE-8776 Eviction policy MBeans are never registered if evictionPolicyFactory is used

> Revert of commit makes test passing.
> Locally test also failed. Failed with message
> {noformat}
> Unexpected cache name for org.apache.ignite.internal.processors.cache.GridCacheLifecycleAwareSelfTest$TestEvictionPolicy@322714f4
expected:<cache> but was:<null>
> {noformat}
> Message of failure seems to be related to TestEvictionPolicy instance from test class.

> Seems that returing call to cctx.kernalContext (). resource (). injectCacheName (rsrc,
cfg.getName ()); should fix issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message