ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8896) Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()
Date Sat, 03 Nov 2018 20:36:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674193#comment-16674193
] 

ASF GitHub Bot commented on IGNITE-8896:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/ignite/pull/5225


> Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()
> ---------------------------------------------------------------
>
>                 Key: IGNITE-8896
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8896
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Dmitry Karachentsev
>            Assignee: Rodion
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.8
>
>
> Javadoc for TcpCommunicationSpi.setSlowClientQueueLimit() says that is should be set
to value equal to TcpCommunicationSpi.getMessageQueueLimit().
> But this is wrong, because first checks back pressure limit and sender thread will be
blocked before slow client check. Also, warning checks the value correctly, but message should
be "...greater or equal...":
> {code:java}
> if (slowClientQueueLimit > 0 && msgQueueLimit > 0 && slowClientQueueLimit
>= msgQueueLimit) {
>             U.quietAndWarn(log, "Slow client queue limit is set to a value greater than
message queue limit " +
>                 "(slow client queue limit will have no effect) [msgQueueLimit=" + msgQueueLimit
+
>                 ", slowClientQueueLimit=" + slowClientQueueLimit + ']');
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message