From issues-return-77039-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Oct 1 11:27:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EC958180660 for ; Mon, 1 Oct 2018 11:27:02 +0200 (CEST) Received: (qmail 92546 invoked by uid 500); 1 Oct 2018 09:27:02 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 92537 invoked by uid 99); 1 Oct 2018 09:27:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Oct 2018 09:27:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 950BFC69A9 for ; Mon, 1 Oct 2018 09:27:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id raXwWzdKEzFz for ; Mon, 1 Oct 2018 09:27:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AF0405F24A for ; Mon, 1 Oct 2018 09:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 53DB4E01C1 for ; Mon, 1 Oct 2018 09:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 15FE723F99 for ; Mon, 1 Oct 2018 09:27:00 +0000 (UTC) Date: Mon, 1 Oct 2018 09:27:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-9741) SegmentArchivedStorage and SegmentCompressStorage remain `iterrupted` after de-activation occurs before activation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-9741?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166= 33761#comment-16633761 ]=20 ASF GitHub Bot commented on IGNITE-9741: ---------------------------------------- GitHub user akalash opened a pull request: https://github.com/apache/ignite/pull/4878 IGNITE-9741 SegmentAware recreated every activation =20 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9741 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4878.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4878 =20 ---- commit 3877ea5ec9b9e4e602ccce198c60ecfff07f8904 Author: Anton Kalashnikov Date: 2018-10-01T09:26:01Z IGNITE-9741 SegmentAware recreated every activation ---- > SegmentArchivedStorage and SegmentCompressStorage remain `iterrupted` aft= er de-activation occurs before activation > -------------------------------------------------------------------------= ----------------------------------------- > > Key: IGNITE-9741 > URL: https://issues.apache.org/jira/browse/IGNITE-9741 > Project: Ignite > Issue Type: Bug > Affects Versions: 2.6 > Reporter: Maxim Muzafarov > Assignee: Anton Kalashnikov > Priority: Critical > Fix For: 2.7 > > > The {{FileWriteAheadLogManager}} now contains: > {{private final SegmentAware segmentAware;}} > =C2=A0 > The SegmentAware have the `interrupt()` method: > {code:java|title=3DSegmentAware:216} > /** > * Interrupt waiting on related objects. > */ > public void interrupt() { > segmentArchivedStorage.interrupt(); > segmentCompressStorage.interrupt(); > segmentCurrStateStorage.interrupt(); > } > {code} > =C2=A0 > Method at the {{FileWriteAheadLogManager}} de-activation sets (e.g. for S= egmentArchivedStorage) `interrupted` filed to `true` value but never revert= it to `false` after activation. > {code:java|title=3DSegmentArchivedStorage:114} > /** > * Interrupt waiting on this object. > */ > synchronized void interrupt() { > interrupted =3D true; > notifyAll(); > } > {code} > =C2=A0 > So, the SegmentArchivedStorage after de-activation always remain interrup= ted.=20 > This can lead to undefined behaviour e.g. exchange worker hangs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)