From issues-return-78479-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Oct 15 15:05:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2BD24180674 for ; Mon, 15 Oct 2018 15:05:03 +0200 (CEST) Received: (qmail 32277 invoked by uid 500); 15 Oct 2018 13:05:02 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 32268 invoked by uid 99); 15 Oct 2018 13:05:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Oct 2018 13:05:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C61BC1822BE for ; Mon, 15 Oct 2018 13:05:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MZEnp0XLwK9h for ; Mon, 15 Oct 2018 13:05:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B9E385F4ED for ; Mon, 15 Oct 2018 13:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5435FE0101 for ; Mon, 15 Oct 2018 13:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1A85223F8E for ; Mon, 15 Oct 2018 13:05:00 +0000 (UTC) Date: Mon, 15 Oct 2018 13:05:00 +0000 (UTC) From: "Vladimir Ozerov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-9447) Benchmarks hangs intemittently due to distributed race condition. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650169#comment-16650169 ] Vladimir Ozerov commented on IGNITE-9447: ----------------------------------------- [~pkouznet], Fix looks good, but let's make that we do not break anything. We need to rerun standard benchmark suite to confirm that. > Benchmarks hangs intemittently due to distributed race condition. > ----------------------------------------------------------------- > > Key: IGNITE-9447 > URL: https://issues.apache.org/jira/browse/IGNITE-9447 > Project: Ignite > Issue Type: Bug > Components: sql > Reporter: Pavel Kuznetsov > Assignee: Pavel Kuznetsov > Priority: Minor > > If we run more than one yardstick driver, benchmark hangs intermittently. > We've got yardstick's base driver class org.apache.ignite.yardstick.IgniteAbstractBenchmark it has logic to wait all the nodes in the cluster. > {noformat} > final CountDownLatch nodesStartedLatch = new CountDownLatch(1); > ignite().events().localListen(new IgnitePredicate() { > @Override public boolean apply(Event gridEvt) { > if (nodesStarted()) > nodesStartedLatch.countDown(); > return true; > } > }, EVT_NODE_JOINED); > if (!nodesStarted()) { > println(cfg, "Waiting for " + (args.nodes() - 1) + " nodes to start..."); > nodesStartedLatch.await(); > } > {noformat} > This code is executed on every driver node. > If we want to close local ignite instance just after cluster is ready (containing expected number of nodes), sometimes we'll have dead lock: > 1) cluster contains N-1 nodes, all nodes are waiting for the Nth node. > 2) Nth node is connected, cluster receives message, waitForNodes code of Nth node is not executed. > 3) N-1 nodes got this message and stop waiting. > 4) N-1 thinks that cluster is ready and call ignite.close() on their local instances > 5) Nth node starts waiting for cluster to contain number of nodes, but N-1 of them closed their instances > 6) Nth node is waiting infinitely. > We can avoid this problem if we use distributed CountDownLatch -- This message was sent by Atlassian JIRA (v7.6.3#76005)