From issues-return-77677-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sat Oct 6 15:06:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3631618061A for ; Sat, 6 Oct 2018 15:06:06 +0200 (CEST) Received: (qmail 850 invoked by uid 500); 6 Oct 2018 13:06:05 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 841 invoked by uid 99); 6 Oct 2018 13:06:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Oct 2018 13:06:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C90BE1A11DA for ; Sat, 6 Oct 2018 13:06:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JTZ6W1V-8ztf for ; Sat, 6 Oct 2018 13:06:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F17795F533 for ; Sat, 6 Oct 2018 13:06:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6A196E25B2 for ; Sat, 6 Oct 2018 13:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5225A24763 for ; Sat, 6 Oct 2018 13:06:00 +0000 (UTC) Date: Sat, 6 Oct 2018 13:06:00 +0000 (UTC) From: "Nikolai Kulagin (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Issue Comment Deleted] (IGNITE-9165) FindBugs: Methods may fail to close stream in core module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-9165?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolai Kulagin updated IGNITE-9165: ------------------------------------ Comment: was deleted (was: {panel:title=3DNo blockers found!|borderStyle=3Ddashed|borderColor=3D= #ccc|titleBGColor=3D#D6F7C1}{panel} [TeamCity Run All|http://ci.ignite.apache.org/viewLog.html?buildId=3D201437= 5&buildTypeId=3DIgniteTests24Java8_RunAll]) > FindBugs: Methods may fail to close stream in core module > --------------------------------------------------------- > > Key: IGNITE-9165 > URL: https://issues.apache.org/jira/browse/IGNITE-9165 > Project: Ignite > Issue Type: Bug > Components: binary > Affects Versions: 2.6 > Reporter: Nikolai Kulagin > Assignee: Nikolai Kulagin > Priority: Minor > Labels: newbie > Fix For: 2.8 > > Attachments: findbugs-result-apache-ignite[ignite-core]_2018_08_0= 2_12_38_02.html > > > The method creates an IO stream object, does not assign it to any fields,= pass it to other methods that might close it, or return it, and does not a= ppear to close the stream on all paths out of the method.=C2=A0 This may re= sult in a file descriptor leak. > Example: > =C2=A0 > {code:java} > // GridCacheAbstractLoadTest#GridCacheAbstractLoadTest() > try { > props.load(new FileReader(GridTestUtils.resolveIgnitePath( > "modules/tests/config/cache-load.properties"))); > } > catch (IOException e) { > throw new RuntimeException(e); > }{code} > =C2=A0 > One of possible solutions: > {code:java} > try (Reader reader =3D new FileReader(GridTestUtils.resolveIgnitePath( > "modules/tests/config/cache-load.properties"))) { > props.load(reader); > } > catch (IOException e) { > throw new RuntimeException(e); > }{code} > List of classes in "core" module: > =C2=A0 > +org.apache.ignite.internal:+=C2=A0 =C2=A0 > * *BinaryContext*#classesInPackage(String) > * *GridClientJdkMarshaller*#marshal(Object, int) > * *IgniteExplicitImplicitDeploymentSelfTest*$GridDeploymentResourceTestJ= ob#execute() > * *OptimizedObjectStreamSelfTest*#testReadLine() > * *PageIdDistributionTest*#_testRealHistory() > * *HttpIgniteUpdatesChecker*#getUpdates(boolean) > * *IpcSharedMemoryNativeLoaderSelfTest*#readStreams(Process) > +org.apache.ignite:+ > * *GridCacheAbstractLoadTest*#GridCacheAbstractLoadTest() > * *GridTestUtils*.sslContext() -- This message was sent by Atlassian JIRA (v7.6.3#76005)