From issues-return-78139-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Oct 11 09:43:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B122818064A for ; Thu, 11 Oct 2018 09:43:04 +0200 (CEST) Received: (qmail 81039 invoked by uid 500); 11 Oct 2018 07:43:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 81030 invoked by uid 99); 11 Oct 2018 07:43:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Oct 2018 07:43:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 47996183E40 for ; Thu, 11 Oct 2018 07:43:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id D2w3dsH5FlHT for ; Thu, 11 Oct 2018 07:43:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3AF8B5F2A9 for ; Thu, 11 Oct 2018 07:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 70543E0177 for ; Thu, 11 Oct 2018 07:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 13A0C247FD for ; Thu, 11 Oct 2018 07:43:00 +0000 (UTC) Date: Thu, 11 Oct 2018 07:43:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-9133) MVCC: Proper empty DHT transactions handling. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-9133?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166= 46067#comment-16646067 ]=20 ASF GitHub Bot commented on IGNITE-9133: ---------------------------------------- Github user devozerov closed the pull request at: https://github.com/apache/ignite/pull/4943 > MVCC: Proper empty DHT transactions handling. > --------------------------------------------- > > Key: IGNITE-9133 > URL: https://issues.apache.org/jira/browse/IGNITE-9133 > Project: Ignite > Issue Type: Bug > Components: mvcc, sql > Reporter: Roman Kondakov > Assignee: Vladimir Ozerov > Priority: Major > Fix For: 2.7 > > > In the cases when DHT=C2=A0transaction is empty (i.e. no keys were enlist= ed) after the enlist step, we need to rollback local DHT transaction to exc= lude it from the further transaction flow in order to performance=C2=A0incr= easing. > An ordinary Dht tx rollback {{GridDhtTxLocal#rollbackDhtLocalAsync}}=C2= =A0is not suitable in this situation because it adds tx to {{IgniteTxManage= r#completedVersHashMap}}=C2=A0which is unacceptable because this=C2=A0actio= n prevents possible Dht transaction creation if the next tx statements enli= st some keys=C2=A0at this node in the future. As well as direct tx map clea= ning by means of {{IgniteTxManager#rollbackTx(tx, true, true)}}=C2=A0is not= an aid because leads to grid hanging due to undiscovered reasons.=C2=A0=C2= =A0In=C2=A0order to reproduce hanging you need to reapply commit=C2=A0d231a= 81 and run {{CacheMvccPartitionedSqlCoordinatorFailoverTest}}. Example of h= anged thread stack is listed below. > Our goal is the proper Dht transaction rollback without adding it to=C2= =A0{{IgniteTxManager#completedVersHashMap.}} > {code:java} > Thread [name=3D"writer-2", id=3D2281, state=3DWAITING, blockCnt=3D40, wai= tCnt=3D10260] > at sun.misc.Unsafe.park(Native Method) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:3= 04) > at o.a.i.i.util.future.GridFutureAdapter.get0(GridFutureAdapter.j= ava:177) > at o.a.i.i.util.future.GridFutureAdapter.get(GridFutureAdapter.ja= va:140) > at o.a.i.i.processors.query.h2.DmlStatementsProcessor.executeUpda= teStatement(DmlStatementsProcessor.java:560) > at o.a.i.i.processors.query.h2.DmlStatementsProcessor.updateSqlFi= elds(DmlStatementsProcessor.java:185) > at o.a.i.i.processors.query.h2.DmlStatementsProcessor.updateSqlFi= eldsDistributed(DmlStatementsProcessor.java:358) > at o.a.i.i.processors.query.h2.IgniteH2Indexing.doRunPrepared(Ign= iteH2Indexing.java:2132) > at o.a.i.i.processors.query.h2.IgniteH2Indexing.querySqlFields(Ig= niteH2Indexing.java:2083) > at o.a.i.i.processors.query.GridQueryProcessor$4.applyx(GridQuery= Processor.java:2139) > at o.a.i.i.processors.query.GridQueryProcessor$4.applyx(GridQuery= Processor.java:2134) > at o.a.i.i.util.lang.IgniteOutClosureX.apply(IgniteOutClosureX.ja= va:36) > at o.a.i.i.processors.query.GridQueryProcessor.executeQuery(GridQ= ueryProcessor.java:2682) > at o.a.i.i.processors.query.GridQueryProcessor.querySqlFields(Gri= dQueryProcessor.java:2148) > at o.a.i.i.processors.cache.IgniteCacheProxyImpl.query(IgniteCach= eProxyImpl.java:668) > at o.a.i.i.processors.cache.IgniteCacheProxyImpl.query(IgniteCach= eProxyImpl.java:619) > at o.a.i.i.processors.cache.GatewayProtectedCacheProxy.query(Gate= wayProtectedCacheProxy.java:388) > at o.a.i.i.processors.cache.mvcc.CacheMvccAbstractTest.removeSql(= CacheMvccAbstractTest.java:832) > at o.a.i.i.processors.cache.mvcc.CacheMvccAbstractTest.access$400= (CacheMvccAbstractTest.java:104) > at o.a.i.i.processors.cache.mvcc.CacheMvccAbstractTest$2.apply(Ca= cheMvccAbstractTest.java:494) > at o.a.i.i.processors.cache.mvcc.CacheMvccAbstractTest$2.apply(Ca= cheMvccAbstractTest.java:401) > at o.a.i.i.processors.cache.mvcc.CacheMvccAbstractTest$9.call(Cac= heMvccAbstractTest.java:1294) > at o.a.i.i.processors.cache.mvcc.CacheMvccAbstractTest$9.call(Cac= heMvccAbstractTest.java:1289) > at o.a.i.testframework.GridTestThread.run(GridTestThread.java:86) > {code} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)