ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-10023) Improve ListeningTestLogger for wait conditions.
Date Tue, 30 Oct 2018 15:43:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668903#comment-16668903
] 

ASF GitHub Bot commented on IGNITE-10023:
-----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/ignite/pull/5191


> Improve ListeningTestLogger for wait conditions.
> ------------------------------------------------
>
>                 Key: IGNITE-10023
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10023
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Amelchev Nikita
>            Assignee: Amelchev Nikita
>            Priority: Major
>             Fix For: 2.8
>
>
> [Dev-list discussion.|http://apache-ignite-developers.2346864.n4.nabble.com/Unreliable-checks-in-tests-for-string-presence-in-GridStringLogger-contents-td30802.html]
> Method LogListener.check() should be boolean type.
> It'll be useful for wait for conditions and code readability:
> For now:
> {code:java}
> waitForCondition(() -> { 
>  try { 
>    lsnr.check(); 
>    return true; 
>  } 
>  catch (AssertionError ignored) { 
>    return false; 
>  } 
> }, timeout); 
> {code}
> After improvement:
> {code:java}
> waitForCondition(lsnr::check, timeout);
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message