ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html
Date Mon, 08 Oct 2018 15:07:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641981#comment-16641981
] 

ASF GitHub Bot commented on IGNITE-9770:
----------------------------------------

SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers'
button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223332273
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##########
 @@ -355,59 +384,82 @@ function triggerBuild(serverId, suiteId, branchName, top, observe,
ticketId) {
     });
 }
 
-function triggerBuilds(serverId, suiteIdList, branchName, top) {
-    var res = "Trigger builds at server: " + serverId + "<br>" +
-        "Branch:" + branchName + "<br>Top: " + top + "<br>";
+function triggerBuilds(serverId, suiteIdList, branchName, top, observe, ticketId) {
+    var possibleBlockersNotFound = suiteIdList.length === 0;
+    var res = "";
 
-    var partsOfStr = suiteIdList.split(',');
+    if (possibleBlockersNotFound) {
 
 Review comment:
   Remove braces for one-line `if` statement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Re-run possible blockers from pr.html
> -------------------------------------
>
>                 Key: IGNITE-9770
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9770
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Nikolai Kulagin
>            Assignee: Nikolai Kulagin
>            Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run possible
blockers&Comment JIRA, so the user re-run the possible tests and does not wait for them
to complete,but learn about the completed tests from the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message