ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9770) Re-run possible blockers from pr.html
Date Thu, 04 Oct 2018 12:19:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638138#comment-16638138
] 

ASF GitHub Bot commented on IGNITE-9770:
----------------------------------------

SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers'
button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642529
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/TriggerBuild.java
 ##########
 @@ -195,31 +196,42 @@ private String observeJira(
     @GET
     @Path("triggerBuilds")
     public SimpleResult triggerBuilds(
-        @Nullable @QueryParam("serverId") String serverId,
+        @Nullable @QueryParam("serverId") String srvId,
         @Nullable @QueryParam("branchName") String branchName,
         @NotNull @QueryParam("suiteIdList") String suiteIdList,
-        @Nullable @QueryParam("top") Boolean top) {
+        @Nullable @QueryParam("top") Boolean top,
+        @Nullable @QueryParam("observe") Boolean observe,
+        @Nullable @QueryParam("ticketId") String ticketId) {
+
+        String jiraRes = "";
 
         final ICredentialsProv prov = ICredentialsProv.get(req);
 
-        if (!prov.hasAccess(serverId))
-            throw ServiceUnauthorizedException.noCreds(serverId);
+        if (!prov.hasAccess(srvId))
+            throw ServiceUnauthorizedException.noCreds(srvId);
 
         List<String> strings = Arrays.asList(suiteIdList.split(","));
         if (strings.isEmpty())
             return new SimpleResult("Error: nothing to run");
 
-        final ITeamcity helper = CtxListener.getTcHelper(context).server(serverId, prov);
+        ITcHelper helper = CtxListener.getTcHelper(context);
+
+        final ITeamcity teamcity = helper.server(srvId, prov);
 
         boolean queueToTop = top != null && top;
 
+        List<Build> buildList = new ArrayList<>();
+
         for (String suiteId : strings) {
             System.out.println("Triggering [ " + suiteId + "," + branchName + "," + "top="
+ queueToTop + "]");
 
-            helper.triggerBuild(suiteId, branchName, false, queueToTop);
+            buildList.add(teamcity.triggerBuild(suiteId, branchName, false, queueToTop));
         }
 
-        return new SimpleResult("OK");
+        if (observe != null && observe)
+            jiraRes = observeJira(srvId, branchName, ticketId, helper, teamcity, prov, buildList.toArray(new
Build[0]));
 
 Review comment:
   Redundant argument `new Build[0]`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Re-run possible blockers from pr.html
> -------------------------------------
>
>                 Key: IGNITE-9770
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9770
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Nikolai Kulagin
>            Assignee: Nikolai Kulagin
>            Priority: Minor
>
> Show button for re-run possible blockers. Also show merged button with re-run possible
blockers&Comment JIRA, so the user re-run the possible tests and does not wait for them
to complete,but learn about the completed tests from the comment to GitHib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message