ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Lantukh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9769) IgniteCacheAtomicProtocolTest.testPutReaderUpdate1 is flaky
Date Thu, 25 Oct 2018 11:43:01 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663626#comment-16663626

Ilya Lantukh commented on IGNITE-9769:

The name *equalsPrimaryAffNodes* is misleading, because it will be *true* if primary nodes
are *not equal*. Also, I think it will be more readable if you simply add something like this
to *if* condition:
|| !dht.context().affinity().primaryByPartition(p, readyVer).equals(affNodes.get(0))

With these check added you should be able to rollback other changes you did in this PR and
the test should pass.

> IgniteCacheAtomicProtocolTest.testPutReaderUpdate1 is flaky
> -----------------------------------------------------------
>                 Key: IGNITE-9769
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9769
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Ryabov Dmitrii
>            Assignee: Ryabov Dmitrii
>            Priority: Trivial
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.8
> {{IgniteCacheAtomicProtocolTest.testPutReaderUpdate1}} and {{IgniteCacheAtomicProtocolTest.testPutReaderUpdate2}} are flaky.
> In the {{#readerUpdateDhtFails}} method we blocks {{GridDhtAtomicNearResponse}} messages
and do put operation. Put should hangs always, but sometimes it doesn't.

This message was sent by Atlassian JIRA

View raw message