ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-9740) [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up to IGNITE-9711)
Date Fri, 28 Sep 2018 22:21:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632597#comment-16632597
] 

Oleg Ignatenko edited comment on IGNITE-9740 at 9/28/18 10:20 PM:
------------------------------------------------------------------

[~chief] as promised when we spoke today I checked ml unit tests. It looks like the only test
class that involves {{IgniteThread}} is the one reported in this ticket (EvaluatorTest).


was (Author: oignatenko):
[~chief] as promised when we spoke today I checked ml unit tests. It looks like the only test
class that involves {{IgniteThread}} is the one reported in this ticket.

> [ML] Remove IgniteThread wrapper from ml unit test EvaluatorTest (follow up to IGNITE-9711)
> -------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-9740
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9740
>             Project: Ignite
>          Issue Type: Bug
>          Components: ml
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Priority: Minor
>             Fix For: 2.8
>
>
> [EvaluatorTest|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/selection/scoring/evaluator/EvaluatorTest.java]
involves {{IgniteThread}} which is in fact not needed there and should be removed.
> {{IgniteThread}} usage is a remainder / copy-paste from older tests and examples that
were using API requiring it. This API has been removed and there is no need for wrapping like
that anymore. For the reference on how to perform suggested cleanup check changes made to
ml examples per IGNITE-9711.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message