ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Kovalenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9736) Public interface DiscoverySpiListener.onDiscovery returns private API class
Date Fri, 28 Sep 2018 10:02:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631643#comment-16631643

Pavel Kovalenko commented on IGNITE-9736:

[~amashenkov] Thank you, Andrew, I see. Do we really need to have this discovery spi listener
in public API? As I see, we explicitly set our internal implementation of that listener on
discovery start. So, a user can override this listener only after grid start. This looks completely
useless and dangerous. I suggest to deprecate method org.apache.ignite.spi.discovery.DiscoverySpi#setListener
and completely remove it in 3.0 release.

> Public interface DiscoverySpiListener.onDiscovery returns private API class
> ---------------------------------------------------------------------------
>                 Key: IGNITE-9736
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9736
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>            Reporter: Andrew Mashenkov
>            Priority: Critical
>             Fix For: 2.7
> Public interface DiscoverySpiListener.onDiscovery returns IgniteInternalFuture of 'internal'
> We should wrap internal future into IgniteFuture of public API.

This message was sent by Atlassian JIRA

View raw message