ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Kuznetsov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9660) Switch default test FailureHandler to StopNodeFailureHandler
Date Fri, 21 Sep 2018 13:56:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623651#comment-16623651
] 

Andrey Kuznetsov commented on IGNITE-9660:
------------------------------------------

It's better to use special test-scope failure handler instead of {{StopNodeFailureHandler}}.
That handler should fail current test method as graceful as possible.

> Switch default test FailureHandler to StopNodeFailureHandler
> ------------------------------------------------------------
>
>                 Key: IGNITE-9660
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9660
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 2.6
>            Reporter: Andrey Kuznetsov
>            Priority: Major
>             Fix For: 2.8
>
>
> {{GridAbstractTest.getFailureHandler()}} returns {{NoOpFailureHandler}} instance. This
often leads to hiding bugs occurring in tests. {{getFailureFailureHandler()}} should return
{{StopNodeFailureHandler}} instead.
> The change assumes re-checking failed tests and set handler to {{NoOpFailureHandler}}
in subclasses where it's really a must.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message