ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9585) Error message sometimes refers nonexisting log file when remote node fails to start
Date Thu, 13 Sep 2018 17:04:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613790#comment-16613790
] 

ASF GitHub Bot commented on IGNITE-9585:
----------------------------------------

GitHub user oignatenko opened a pull request:

    https://github.com/apache/ignite/pull/4753

    IGNITE-9585 Error message sometimes refers nonexisting log file when remote node fails
to start

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-9585

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4753.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4753
    
----
commit 1eeca908a8076a8317947dac8a46845964d1d7ea
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-23T13:13:28Z

    IGNITE-9348 ML examples improvements
    - wip (logging improved)
    -- verified with diffs overview, executing the examples and studying execution logs

commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-23T14:45:57Z

    Revert "IGNITE-9348 ML examples improvements"
    
    This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea.

commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-23T14:57:34Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 9642b233b5701bdad47ebea163079160227c582a
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-28T14:01:11Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-28T15:13:02Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit d2caba67b156674f051f50faebeafe0871bf0914
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-29T13:14:07Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 16775dff51d71ea68b4a3dea98be552130c493ed
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-30T09:00:56Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit aedb59929974fe205b949225c1a338c68c60cfc8
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-30T09:42:38Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 39c6482fcdca506aa33011ed21c98060b4a8c68b
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-30T11:28:05Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 33b32a2760a6559c78283b927e3191180d8ed9e1
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-30T12:31:16Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-30T14:06:34Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-30T16:41:51Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit aacac88db519187413b0fc5ff9d0e55b8f8cff22
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-31T10:12:32Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 897f920dde46022849b13f9fb86dba8e54119a56
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-31T13:57:14Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 114c79e54c1b316006ccc3ff22d20d902f9313df
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-08-31T17:39:16Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit fd6b659bb8be1992618ce4ce91f568a0988b3afa
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-02T06:11:42Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-03T10:27:35Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-04T09:49:44Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-05T10:50:28Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-05T11:45:58Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 480ed78869277d7e32f725ab71bec9621f1ac03a
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-06T07:52:55Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit c99762498f617c0e98ea3062a43c0b30092166ef
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-06T14:45:04Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 2e17175225c72f747d370b5fee96f8be69d6d2cb
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-06T17:33:54Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-07T13:38:51Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit f9308abc3edef7910803ec450977f9e490c0dfba
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-10T10:09:39Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit b6a3401c6dfb342570919dc4e3b87b82e94d2372
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-10T15:56:47Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit e84ea59c8597a1b9fe47ef315ad54bd31f28adff
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-11T14:06:25Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

commit 7fbc778fdeb2fed49c2873859f4b49347bab3170
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-11T16:18:32Z

    IGNITE-9545 IgniteProjectionStartStopRestartSelfTest: misleading javadocs etc
    - fixes for code style warnings reported by IDEA
    -- verified with diffs overview, clean rebuild and trial execution of modified tests on
my machine

commit bf34339d40843d201941f88d6a9afabb76f358dc
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-11T16:20:19Z

    Revert "IGNITE-9545 IgniteProjectionStartStopRestartSelfTest: misleading javadocs etc"
    
    This reverts commit 7fbc778fdeb2fed49c2873859f4b49347bab3170.

commit 9624fc4443e745093ab67086e669d012b251d62f
Author: Oleg Ignatenko <oignatenko@...>
Date:   2018-09-11T17:02:33Z

    Merge branch 'master' of https://github.com/apache/ignite into master-ml

----


> Error message sometimes refers nonexisting log file when remote node fails to start
> -----------------------------------------------------------------------------------
>
>                 Key: IGNITE-9585
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9585
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Minor
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.7
>
>
> Teamcity build logs sometimes refer to remote node log files that aren't present in build
artifacts ([example|https://ci.ignite.apache.org/viewLog.html?buildTypeId=IgniteTests24Java8_StartNodes&buildId=1849937&branch_IgniteTests24Java8_StartNodes=%3Cdefault%3E]).
> I managed to reproduce this on my machine (details below) and it looks like typically
the root cause of this is error message from [StartNodeCallableImpl|https://github.com/apache/ignite/blob/master/modules/ssh/src/main/java/org/apache/ignite/internal/util/nodestart/StartNodeCallableImpl.java]
referring readers to file that doesn't exist (and it wasn't even created to start with).
> {code:java}
>             return new ClusterStartNodeResultImpl(spec.host(), false, "Remote node could
not start. " +
>                 "See log for details: " + scriptOutputPath);
> {code}
> This is quite painful when one tries to investigate node launching failures because the
misleading message causes one to waste time investigating the problem that doesn't exist (it
appears as if log file was there but somehow disappeared for some mysterious reason).
> ----
> To reproduce the issue locally one can do as follows: first, modify file [start-nodes-custom.sh|https://github.com/apache/ignite/blob/master/modules/core/src/test/bin/start-nodes-custom.sh]
by replacing {{ignite.sh}} with the name of script that doesn't exist, eg {{noignite.sh}}.
After that, execute unit test [IgniteProjectionStartStopRestartSelfTest|https://github.com/apache/ignite/blob/master/modules/ssh/src/test/java/org/apache/ignite/internal/IgniteProjectionStartStopRestartSelfTest.java]
and study its results and logs.
> You will find that {{testCustomScript}} fails - which is expected because name of the
script intended to be executed has changed to one that doesn't exist. Also you will find that
log file for respective node hasn't been created - which is also expected because shell command
fails before creating it. But in the same time test log will refer to mentioned file as if
it exists.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message