ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9569) Web console: use $inject for DI instead of arrays
Date Thu, 20 Sep 2018 07:05:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621588#comment-16621588

ASF GitHub Bot commented on IGNITE-9569:

GitHub user Klaster1 opened a pull request:


    IGNITE-9569 Web console: update DI approach and increase type coverage

    @akuznetsov-gridgain please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-9569

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4794
commit a43b3bac80f99ca1a741e460942efae5257d04b3
Author: Ilya Borisov <klaster1@...>
Date:   2018-09-19T10:03:10Z

    IGNITE-9569 Update directives/service DI and types defined in app.js.

commit 45783bcac2fd28af77858299551cd3f59e8862df
Author: Ilya Borisov <klaster1@...>
Date:   2018-09-20T04:22:46Z

    IGNITE-9569 Update more directives/service DI and types defined in app.js.


> Web console: use $inject for DI instead of arrays
> -------------------------------------------------
>                 Key: IGNITE-9569
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9569
>             Project: Ignite
>          Issue Type: Improvement
>          Components: wizards
>            Reporter: Ilya Borisov
>            Assignee: Ilya Borisov
>            Priority: Minor
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
> To do:
>  1. Remove provider registration by array spread, like this:
> {code:java}
> .service(...serviceArray){code}
>  Instead, use the canonical AngularJS approach:
> {code:java}
> .service('SeriveName', Service){code}
>  2. Do not use array Di syntax for exported symbols:
> {code:java}
> export ['IgniteVersion', 'Confirm', function directive (version, confirm){}]{code}
>  Instead, use $inject property:
> {code:java}
> export function directive(version, confirm) {}
> directive.$inject = ['IgniteVersion', 'Confirm']{code}
> Motivation:
>  The changes above will make older providers accessible to TypeScript, which in turn
will allow to increase type coverage.

This message was sent by Atlassian JIRA

View raw message