ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Borisov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9556) Web console: Babel 7 rc.2 compatibility issues
Date Wed, 12 Sep 2018 07:39:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611703#comment-16611703
] 

Ilya Borisov commented on IGNITE-9556:
--------------------------------------

The issue happens because _AgentManager_ class name property gets changed to _AgentManager_service_AgentManager_
as a part of scope hoisting by _ModuleConcatenationPlugin_.

Relevant issues:
https://github.com/webpack-contrib/uglifyjs-webpack-plugin/issues/234
https://github.com/webpack/webpack/issues/5463

Out options are:
1. Don't rely on class and function names for DI. I prefer this one because in the end we'll
be using strings as DI tokens, which is the canonical AngularJS approach.
2. Disable _ModuleConcatenationPlugin_. This will probably increase production bundle size,
not a good idea.
3. Try [this approach|https://github.com/webpack-contrib/uglifyjs-webpack-plugin/issues/234#issuecomment-369134047].
It introduces unnecessary webpack config compication, so I don't like it.


[~anovikov], [~kuaw26], [~alexdel] what do you think?

> Web console: Babel 7 rc.2 compatibility issues
> ----------------------------------------------
>
>                 Key: IGNITE-9556
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9556
>             Project: Ignite
>          Issue Type: Bug
>          Components: wizards
>            Reporter: Ilya Borisov
>            Assignee: Ilya Borisov
>            Priority: Major
>
> Bebel 7 rc.2 causes at least one breaking issue: AngularJS-module-related run time error
happens when built for production target.
> !screenshot-1.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message