ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Muzafarov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-9341) Notify metastorage listeners right before start of discovery processor
Date Thu, 06 Sep 2018 14:55:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605878#comment-16605878

Maxim Muzafarov commented on IGNITE-9341:


Do we really need to keep {{readMetastore(false);}} call at that place?

Generally, I think this is not fair `read-only` metastorage. 
* {{readMetastorage}} method still changes class {{this.metaStorage}} variable, but, suppose,
we can make it local variable there.
* Inside {{readMetastore}} method we are stopping temporarily created {{PageMemoryEx}}. Suppose,
metastorage instance, for this reason, can be used only once by interface subscribers (they
can't save it as the local variable for the purposes).

Should we also change this? What do you think?

> Notify metastorage listeners right before start of discovery processor
> ----------------------------------------------------------------------
>                 Key: IGNITE-9341
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9341
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>            Reporter: Ivan Rakov
>            Assignee: Vyacheslav Koptilin
>            Priority: Major
>             Fix For: 2.8
> onReadyForRead() is called only for inheritors of MetastorageLifecycleListener interface
which are started prior to GridCacheProcessor. Listeners are notified at the moment of ReadOnlyMetastorage
initialization, which in turn occur during GridCacheDatabaseSharedManager start.
> We can split ReadOnlyMetastorage initialization and notification of listeners - this
will allow all components to subscribe for read-only metastorage ready event.

This message was sent by Atlassian JIRA

View raw message