From issues-return-70891-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Aug 1 09:48:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 515E3180634 for ; Wed, 1 Aug 2018 09:48:03 +0200 (CEST) Received: (qmail 63685 invoked by uid 500); 1 Aug 2018 07:48:02 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 63676 invoked by uid 99); 1 Aug 2018 07:48:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2018 07:48:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DDB8F1805C7 for ; Wed, 1 Aug 2018 07:48:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PUUDqQLOoHW0 for ; Wed, 1 Aug 2018 07:48:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C81435F19B for ; Wed, 1 Aug 2018 07:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5BA4EE0101 for ; Wed, 1 Aug 2018 07:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2171527756 for ; Wed, 1 Aug 2018 07:48:00 +0000 (UTC) Date: Wed, 1 Aug 2018 07:48:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-8158) Missed cleanups if afterTestsStop throws exception MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-8158?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165= 64905#comment-16564905 ]=20 ASF GitHub Bot commented on IGNITE-8158: ---------------------------------------- GitHub user zzzadruga opened a pull request: https://github.com/apache/ignite/pull/4464 IGNITE-8158 Wrap the method afterTestsStopped() call with try/catch b= =E2=80=A6 =E2=80=A6lock You can merge this pull request into a Git repository by running: $ git pull https://github.com/zzzadruga/ignite IGNITE-8158 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4464 =20 ---- commit 67adeb02efb776446075d1939cb3e08afbf36616 Author: zzzadruga Date: 2018-07-31T16:19:53Z IGNITE-8158 Wrap the method afterTestsStopped() call with try/catch blo= ck ---- > Missed cleanups if afterTestsStop throws exception > -------------------------------------------------- > > Key: IGNITE-8158 > URL: https://issues.apache.org/jira/browse/IGNITE-8158 > Project: Ignite > Issue Type: Bug > Affects Versions: 2.4 > Reporter: Maxim Muzafarov > Assignee: Nikolai Kulagin > Priority: Minor > Labels: newbie, test > Fix For: 2.7 > > > Method {{afterTestsStopped}} might throw exception. Contibutor should pro= vide solution for ensuring that all cleanups in {{tearDown}} method would b= e executed in this case. > {code:java|title=3DGridAbstractTest.java} > /** {@inheritDoc} */ > @Override protected void tearDown() throws Exception { > ... > try { > afterTest(); > } > finally { > serializedObj.clear(); > if (isLastTest()) { > ... > afterTestsStopped(); > if (startGrid) > G.stop(getTestIgniteInstanceName(), true); > // Remove counters. > tests.remove(getClass()); > // Remove resources cached in static, if any. > GridClassLoaderCache.clear(); > U.clearClassCache(); > MarshallerExclusions.clearCache(); > BinaryEnumCache.clear(); > } > Thread.currentThread().setContextClassLoader(clsLdr); > clsLdr =3D null; > cleanReferences(); > } > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)