ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Borisov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-9191) Web Console: Cluster saved with empty name in special case
Date Mon, 06 Aug 2018 10:10:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569993#comment-16569993
] 

Ilya Borisov edited comment on IGNITE-9191 at 8/6/18 10:09 AM:
---------------------------------------------------------------

[~kuaw26] to understand why this was happening, you first have to understand to data flow
of configuration edit forms: all cluster configuration edits are done against a copy of config,
which is stored under {{changes.cluster}} path in store. This is done in order to share changes
state across several forms. When user creates a new cluster config, {{Clusters}} service generates
an empty config with default values, _but without a name_, this is the value that goes into
{{changes.cluster}}. The actual cluster name is assigned in {{selectClusterToEdit}} selector,
which is used only on basic/advanced cluster screens and not on advanced entity edit screens.
Because of all of the above, when user saves new cache (or other entity) along with a new
cluster config, the value in {{changes.cluster}} does not have {{name}} property.

In order to fix the issue, I've updated the {{loadAndEditClusterEffect$}} that's responsible
for new cluster object (i.e. the one with default values) creation so it assigns a unique
name too. This will ensure that {{changes.cluster}} always has a name.


was (Author: klaster_1):
[~kuaw26] to understand why this was happening, you first to understand to data flow of configuration
edit forms: all cluster configuration edits are done against a copy of config, which is stored
under {{changes.cluster}} in store. This is done in order to share changes state across several
forms. When user creates a new cluster config, Cluster service generates an empty config with
default values, _but without name_, this is the value that goes into {{changes.cluster}}.
The actual cluster name is assigned in {{selectClusterToEdit}} selector, which is used only
on basic/advanced cluster screens and not on advanced entity edit screens. Because of all
of the above, when user saves new cache (or other entity) along with a new cluster config,
the value in {{changes.cluster}} does not have {{name}} property.

In order to fix the issue, I've updated the {{loadAndEditClusterEffect$}} that's responsible
for new cluster object (i.e. the one with default values) creation so it assigns a unique
name too. This will ensure that {{changes.cluster}} always has a name.

> Web Console: Cluster saved with empty name in special case
> ----------------------------------------------------------
>
>                 Key: IGNITE-9191
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9191
>             Project: Ignite
>          Issue Type: Task
>          Components: wizards
>            Reporter: Alexey Kuznetsov
>            Assignee: Alexey Kuznetsov
>            Priority: Major
>             Fix For: 2.7
>
>
> # Create a new cluster, DON'T save
>  # Open Advanced screen
>  # Go to caches.
>  # Create cache.
>  # Save cache.
>  # Clsuter saved with EMPTY name (bug).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message