ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-9146) Analyse and improve code coverage in ML module
Date Mon, 06 Aug 2018 08:56:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568663#comment-16568663
] 

Oleg Ignatenko edited comment on IGNITE-9146 at 8/6/18 8:55 AM:
----------------------------------------------------------------

Further study of coverage reports revealed some dead code that needs to be removed:

- class {{SmallTrainingDatasetSizeException}}. It was introduced per IGNITE-6880 but the code
that used this class was later changed to go without it per IGNITE-7702
- class {{math.Precision}}. It was introduced (adopted from apache commons math) per IGNITE-5012
but in later changes turned out of extremely low demand (as of now only use is a private constant
in {{AbstractLSQR}}). Per discussion with [~amalykh] who is most involved in this code it
is better to remove. (to avoid confusion, note that there is another class with same name
but in another package: {{selection.scoring.metric.Precision}} - that one is to be kept)
- class {{Isomorphism}}. It was introduced in IGNITE-7322 with the intention to maybe use
it some time later as it implemented a concept that looked like promising back then However
in the further development need for it did not appear and per discussion with author ([~amalykh])
it is currently better to remove it.


was (Author: oignatenko):
Further study of coverage reports revealed some dead code that needs to be removed:

- class {{SmallTrainingDatasetSizeException}}. It was introduced per IGNITE-6880 but the code
that used this class was later changed to go without it per IGNITE-7702
- class {{math.Precision}}. It was introduced (adopted from apache commons math) per IGNITE-5012
but in later changes turned out of extremely low demand (as of now only use is a private constant
in {{AbstractLSQR}}). Per discussion with [~amalykh] who is most involved in this code it
is better to remove. (to avoid confusion, note that there is another class with same name
but in another package: {{selection.scoring.metric.Precision}} - that one is to be kept)

> Analyse and improve code coverage in ML module
> ----------------------------------------------
>
>                 Key: IGNITE-9146
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9146
>             Project: Ignite
>          Issue Type: Task
>          Components: ml
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>             Fix For: 2.7
>
>         Attachments: 20180731-ml-coverage.zip, 20180805.IgniteMLTestSuite.coverage.zip
>
>
> Run code coverage analysis, study results and add missing tests where needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message