ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8673) Reconcile isClient* methods
Date Tue, 14 Aug 2018 13:26:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579789#comment-16579789
] 

ASF GitHub Bot commented on IGNITE-8673:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/ignite/pull/4104


> Reconcile isClient* methods
> ---------------------------
>
>                 Key: IGNITE-8673
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8673
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Eduard Shangareev
>            Assignee: Eduard Shangareev
>            Priority: Critical
>             Fix For: 2.7
>
>
> Now isClient (Mode, Cache and so on) methods semantic could mean different things:
> -the same as IgniteConfiguration#setClientMode;
> -or the way how a node is connected to cluster (in the ring or not).
> Almost in all cases, we need the first thing, but actually methods could return second.
> For example, ClusterNode.isClient means second, but all of us use as first.
> So, I propose to make all methods return first.
> And if there are places which require second replace them with the usage of forceClientMode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message