ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Goncharuk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8673) Reconcile isClient* methods
Date Fri, 10 Aug 2018 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576468#comment-16576468
] 

Alexey Goncharuk commented on IGNITE-8673:
------------------------------------------

Merged master and re-triggered TC build: https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&branch_IgniteTests24Java8=pull%2F4104%2Fhead

> Reconcile isClient* methods
> ---------------------------
>
>                 Key: IGNITE-8673
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8673
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Eduard Shangareev
>            Assignee: Eduard Shangareev
>            Priority: Critical
>             Fix For: 2.7
>
>
> Now isClient (Mode, Cache and so on) methods semantic could mean different things:
> -the same as IgniteConfiguration#setClientMode;
> -or the way how a node is connected to cluster (in the ring or not).
> Almost in all cases, we need the first thing, but actually methods could return second.
> For example, ClusterNode.isClient means second, but all of us use as first.
> So, I propose to make all methods return first.
> And if there are places which require second replace them with the usage of forceClientMode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message