ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Ignatenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-9146) Analyse and improve code coverage in ML module
Date Tue, 31 Jul 2018 15:33:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-9146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563792#comment-16563792
] 

Oleg Ignatenko edited comment on IGNITE-9146 at 7/31/18 3:32 PM:
-----------------------------------------------------------------

Attached preliminary coverage report: [^20180731-ml-coverage.zip] (note it accounts for removal
of some dead code that was performed per IGNITE-9124)


This data is supposed to be a combined coverage obtained by running examples from [IgniteExamplesMLTestSuite|https://github.com/apache/ignite/blob/master/examples/src/test/java/org/apache/ignite/testsuites/IgniteExamplesMLTestSuite.java]
and [unit and performance tests in ML module|https://github.com/apache/ignite/tree/master/modules/ml/src/test].
Overall it looks fairly okay and needing only relatively minor improvements.

Per brief study of this data it looks like the following things need to be done:

# Ensure that {{IgniteExamplesMLTestSuite}} launches all examples that are possible to run
automatically. Currently it looks like missing some (eg {{tutorial}} and {{tree}} examples),
which is not good because as a result Teamcity build can't reliably tell whether all examples
can run out of the box or not. Examples not invoked from this test suite need to be discovered
and either integrated into it or somehow documented in test suite comments with the explanation
of why these should not be run from it.
# Ensure that in unit tests, invoking [IgniteMLTestSuite|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/IgniteMLTestSuite.java]
provides as much coverage as possible:
## If some unit tests aren't yet invoked from the test suite, these need to be integrated
## If some tests can't be executed from this test suite, these need to be documented in comments
(eg tests in package {{org.apache.ignite.ml.nn.performance}}) 
## If some important unit tests are missing these need to be added (eg for {{org.apache.ignite.ml.optimization.LossFunctions}}).
Note consider that for really important functionality it may be insufficient to have it covered
only in examples but also a proper verification in module unit tests should be added.


was (Author: oignatenko):
attached preliminary coverage report: [^20180731-ml-coverage.zip] (note it accounts for removal
of some dead code that was performed per IGNITE-9124)

> Analyse and improve code coverage in ML module
> ----------------------------------------------
>
>                 Key: IGNITE-9146
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9146
>             Project: Ignite
>          Issue Type: Task
>          Components: ml
>    Affects Versions: 2.6
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>             Fix For: 2.7
>
>         Attachments: 20180731-ml-coverage.zip
>
>
> Run code coverage analysis, study results and add missing tests where needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message