ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Karachentsev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8944) TcpDiscoverySpi: set connection check frequency to fixed value
Date Mon, 16 Jul 2018 10:03:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545021#comment-16545021
] 

Dmitry Karachentsev commented on IGNITE-8944:
---------------------------------------------

[TC | https://ci.ignite.apache.org/viewLog.html?buildId=1487349&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Spi]

> TcpDiscoverySpi: set connection check frequency to fixed value
> --------------------------------------------------------------
>
>                 Key: IGNITE-8944
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8944
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.5
>            Reporter: Dmitry Karachentsev
>            Assignee: Dmitry Karachentsev
>            Priority: Major
>              Labels: discovery
>             Fix For: 2.7
>
>
> Now connCheckFreq value calculated by some not obvious code:
> {code:java}
> private void initConnectionCheckFrequency() {
>             if (spi.failureDetectionTimeoutEnabled())
>                 connCheckThreshold = spi.failureDetectionTimeout();
>             else
>                 connCheckThreshold = Math.min(spi.getSocketTimeout(), spi.metricsUpdateFreq);
>             for (int i = 3; i > 0; i--) {
>                 connCheckFreq = connCheckThreshold / i;
>                 if (connCheckFreq > 10)
>                     break;
>             }
>             assert connCheckFreq > 0;
>             if (log.isInfoEnabled())
>                 log.info("Connection check frequency is calculated: " + connCheckFreq);
>         }
> {code}
> It should be replaced with constant.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message