ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Valentin Kulichenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8880) Add setIgnite() in SpringCacheManager and SpringTransactionManager
Date Mon, 09 Jul 2018 20:17:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537509#comment-16537509
] 

Valentin Kulichenko commented on IGNITE-8880:
---------------------------------------------

[~aakhmedov], here are my comments:
# When printing out debug messages, you should always check that DEBUG mode is enabled. Like
this:
{code}
if (log.isDebugEnabled()) {
    log.debug("...");
{code}
# We need to have tests for different ways of configuring STM and SCM. Please check if we
have any and add missing ones (including for the newly added method).
# I believe {{transactionConcurrency}} in STM should be set regardless of how Ignite is acquired.
Currently this will not happen if one uses the new method, because the code doing this is
within {{if (ignite == null)}} path. Please fix and make sure this is tested as well.

> Add setIgnite() in SpringCacheManager and SpringTransactionManager
> ------------------------------------------------------------------
>
>                 Key: IGNITE-8880
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8880
>             Project: Ignite
>          Issue Type: Improvement
>          Components: spring
>            Reporter: Amir Akhmedov
>            Assignee: Amir Akhmedov
>            Priority: Major
>              Labels: newbie
>             Fix For: 2.7
>
>
> Neet to add setIgnite() in SpringCacheManager and SpringTransactionManager to make explicit
injection of Ignite instance.
> For more details refer: https://issues.apache.org/jira/browse/IGNITE-8740?focusedCommentId=16520894&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16520894



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message