ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy Pavlov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-8776) Eviction policy MBeans are never registered if evictionPolicyFactory is used
Date Thu, 12 Jul 2018 16:05:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541862#comment-16541862
] 

Dmitriy Pavlov edited comment on IGNITE-8776 at 7/12/18 4:04 PM:
-----------------------------------------------------------------

Merged to master. 

I've 
- updated PR in accordance with code style, 
- added empty lines after variable declaration and before return.
- added test to suite so it could be run on TC.

[~slukyanov], thank you for review. [~kcheng.mvp] thank you for contribution.


was (Author: dpavlov):
Merged to master.

I've 
- updated PR in accordance with code style, 
- added empty lines after variable declaration and before return.
- added test to suite so it could be run on TC.

[~slukyanov], thank you for review

> Eviction policy MBeans are never registered if evictionPolicyFactory is used
> ----------------------------------------------------------------------------
>
>                 Key: IGNITE-8776
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8776
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Stanislav Lukyanov
>            Assignee: kcheng.mvp
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.7
>
>
> Eviction policy MBeans, such as LruEvictionPolicyMBean, are never registered if evictionPolicyFactory
is set instead of evictionPolicy (the latter is deprecated).
> This happens because GridCacheProcessor::registerMbean attempts to find either an *MBean
interface or IgniteMBeanAware interface on the passed object. It works for LruEvictionPolicy
but not for LruEvictionPolicyFactory (which doesn't implement these interfaces).
> The code needs to be adjusted to handle factories correctly.
> New tests are needed to make sure that all standard beans are registered (IgniteKernalMbeansTest
does that for kernal mbeans - need the same for cache beans).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message