ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8714) CacheEntryEvent.getOldValue should be available
Date Thu, 05 Jul 2018 13:08:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533624#comment-16533624
] 

ASF GitHub Bot commented on IGNITE-8714:
----------------------------------------

GitHub user NSAmelchev opened a pull request:

    https://github.com/apache/ignite/pull/4313

    IGNITE-8714

    For IGNITE-8714.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NSAmelchev/ignite ignite-8714

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4313
    
----
commit 9ab86440476be4b499c618d00a8729db39528dd6
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-04T09:11:31Z

    ignite-8687 Add JCache TCK 1.1.0 to TC
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit 187a644b99ae8c0a29f44b2ab46a084cd30af370
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-07T09:37:51Z

    ignite-8714 CacheEntryEvent.getOldValue should be available
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit f626675f622d50b86fb3d5d9643f365ed67b4713
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-14T10:05:40Z

    Revert "ignite-8687 Add JCache TCK 1.1.0 to TC"
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit 525da4854829855efa29b7a737b1a561180afa52
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-19T10:35:59Z

    ignite-8714 fix problems with ignite's tests
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit 6f701a090003dd69b28d46559d22665e1ebe042b
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-21T08:55:33Z

    temp commit
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit 75ff37961ea72e782deaf6b73b71a57bc5009de8
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-21T09:55:46Z

    fix problems with tests
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit f59f9ee66b5afd4848d83d020dd0b69746ea10f6
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-21T12:25:32Z

    fix our tests
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit 4d9ae8b680e1d27e8455b92854f3b2b1fbd89099
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-21T16:09:07Z

    fix prblms with tests
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit 6d2960c00d07170618fb15edd6dde8d42b38aff9
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-22T11:31:12Z

    fx pr t
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit c791f9a4ee010519c8deb6ede793a02f4b34aa31
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-22T12:50:05Z

    tempcmt1
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit da17a41b10f66a82fd680873a7c5240db861fa5a
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-22T15:35:50Z

    tmp cmt
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit 79a0d4e59ecc7d35427f5724b1afb225c4004a9d
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-27T11:24:00Z

    fix hang
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit cc37a46c8032694448556135e0e3e8033c615235
Author: Alexander Menshikov <sharplermc@...>
Date:   2018-06-27T16:49:53Z

    remove temp files
    
    Signed-off-by: NSAmelchev <nsamelchev@gmail.com>

commit b123a276801060cab722faba1ba5d0db08e204d8
Author: NSAmelchev <nsamelchev@...>
Date:   2018-07-05T13:05:16Z

    revert optimization

----


> CacheEntryEvent.getOldValue should be available
> -----------------------------------------------
>
>                 Key: IGNITE-8714
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8714
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Alexander Menshikov
>            Assignee: Amelchev Nikita
>            Priority: Major
>              Labels: iep-21
>             Fix For: 2.7
>
>
> A table is copied from speck changing discussion:
> When CacheEntryListenerConfiguration#isOldValueRequired is *true*:
> ||CacheEntryEvent Method||CreatedListener||UpdatedListener||Removed/Expired Listener||
> |getValue()|_value_|_value_|_oldValue_|
> |getOldValue()|null|_oldValue_|_oldValue_|
> The last column is new behavior for #getValue().
> Сurrent master fails with this reason on following tests:
>  * CacheListenerTest.testFilteredListener
>  * CacheListenerTest.testCacheEntryListener
> I have to say tests testFilteredListener and testCacheEntryListener also fail in `afterTests`
section because of IGNITE-8715, so PR will not change the number of failed tests if ignite-8715
unfixed. But it will change the reason – please see the log.
> Please see also link on JCache TCK and speck 1.1.0 changes.
>  
> *UPD:*
> There are a lot of our tests wich going to break by this change. Also, we use events
in Services deployment, which will be affected too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message