From issues-return-66635-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Jun 6 18:50:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9846418067B for ; Wed, 6 Jun 2018 18:50:04 +0200 (CEST) Received: (qmail 43491 invoked by uid 500); 6 Jun 2018 16:50:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 43476 invoked by uid 99); 6 Jun 2018 16:50:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2018 16:50:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 53A8A1A31E7 for ; Wed, 6 Jun 2018 16:50:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 68XvwCddzQYo for ; Wed, 6 Jun 2018 16:50:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0E9765FD3F for ; Wed, 6 Jun 2018 16:50:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 56B9FE0230 for ; Wed, 6 Jun 2018 16:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 725E22109E for ; Wed, 6 Jun 2018 16:50:00 +0000 (UTC) Date: Wed, 6 Jun 2018 16:50:00 +0000 (UTC) From: "Stanislav Lukyanov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (IGNITE-8726) Highlight that memory metrics are local for a node in the docs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Stanislav Lukyanov created IGNITE-8726: ------------------------------------------ Summary: Highlight that memory metrics are local for a node in the docs Key: IGNITE-8726 URL: https://issues.apache.org/jira/browse/IGNITE-8726 Project: Ignite Issue Type: Improvement Components: documentation Reporter: Stanislav Lukyanov Memory Metrics (DataRegionMetrics and DataStorageMetrics) in Ignite are local for each node. However, this is not highlighted in the documentation enough. The code snippets suggest to just call `ignite.dataRegionMetrics()` which seems to be a bit at odds with the general use case of Ignite servers being started via ignite.sh. It would be good to have an easily noticeable warning that the metrics will only return data for the local node (and that, for example, on client they would typically always print 0). Also, would be nice to include a couple of practical approaches other than JMX to collect metrics. E.g. a snippet of client code getting metrics from all servers: {code} Collection metricsFromNodes = ignite.compute().broadcast(() -> { Ignite ignite = Ignition.localIgnite(); StringBuilder sb = new StringBuilder(); sb.append("Node: " + ignite.name()); for (DataRegionMetrics metrics : ignite.dataRegionMetrics()) { // append metrics to the builder } return sb.toString(); }); for (String metricsString : metricsFromNodes) System.out.println(metricsString); {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)