From issues-return-67033-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Jun 13 14:14:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 33D0C18066C for ; Wed, 13 Jun 2018 14:14:04 +0200 (CEST) Received: (qmail 13945 invoked by uid 500); 13 Jun 2018 12:14:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 13935 invoked by uid 99); 13 Jun 2018 12:14:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2018 12:14:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9827DC16CF for ; Wed, 13 Jun 2018 12:14:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id IIZSQDvNt4zY for ; Wed, 13 Jun 2018 12:14:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 723B75F33D for ; Wed, 13 Jun 2018 12:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D154AE0CCD for ; Wed, 13 Jun 2018 12:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 405DF210AC for ; Wed, 13 Jun 2018 12:14:00 +0000 (UTC) Date: Wed, 13 Jun 2018 12:14:00 +0000 (UTC) From: "Andrey Gura (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-8293) BinaryUtils#isCustomJavaSerialization fails when only readObject is declared in a class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-8293?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165= 11026#comment-16511026 ]=20 Andrey Gura edited comment on IGNITE-8293 at 6/13/18 12:13 PM: --------------------------------------------------------------- [~MihkelJ] Unfortunately, TC run has failed tests due to your change. At le= ast following tests are failed: {noformat} org.apache.ignite.testsuites.IgniteBinaryObjectsTestSuite: org.apache.ignit= e.internal.binary (12) BinaryEnumsSelfTest.testDeclaredBodyEnumNotRegistered =09 BinaryEnumsSelfTest.testDeclaredBodyEnumRegistered =09 BinaryEnumsSelfTest.testNestedBuilderNotRegistered =09 BinaryEnumsSelfTest.testNestedNotRegistered =09 BinaryEnumsSelfTest.testSimpleArrayNotRegistered =09 BinaryEnumsSelfTest.testSimpleArrayRegistered =09 BinaryEnumsSelfTest.testSimpleNotRegistered =09 BinaryEnumsSelfTest.testSimpleRegistered =09 BinaryMarshallerSelfTest.testWriteReplaceInheritable =09 BinaryObjectBuilderAdditionalSelfTest.testEnum =09 BinaryObjectBuilderAdditionalSelfTest.testMetadataChanging =09 BinaryObjectBuilderAdditionalSelfTest.testSimpleTypeFieldOverride =09 org.apache.ignite.testsuites.IgniteBinaryObjectsTestSuite: org.apache.ignit= e.internal.binary.noncompact (4) BinaryMarshallerNonCompactSelfTest.testWriteReplaceInheritable =09 BinaryObjectBuilderAdditionalNonCompactSelfTest.testEnum =09 BinaryObjectBuilderAdditionalNonCompactSelfTest.testMetadataChanging = =09 BinaryObjectBuilderAdditionalNonCompactSelfTest.testSimpleTypeFieldOver= ride =20 {noformat} was (Author: agura): [~MihkelJ] Unfortunately, TC run has failed tests due to your change. At le= ast following changes are failed: {noformat} org.apache.ignite.testsuites.IgniteBinaryObjectsTestSuite: org.apache.ignit= e.internal.binary (12) BinaryEnumsSelfTest.testDeclaredBodyEnumNotRegistered =09 BinaryEnumsSelfTest.testDeclaredBodyEnumRegistered =09 BinaryEnumsSelfTest.testNestedBuilderNotRegistered =09 BinaryEnumsSelfTest.testNestedNotRegistered =09 BinaryEnumsSelfTest.testSimpleArrayNotRegistered =09 BinaryEnumsSelfTest.testSimpleArrayRegistered =09 BinaryEnumsSelfTest.testSimpleNotRegistered =09 BinaryEnumsSelfTest.testSimpleRegistered =09 BinaryMarshallerSelfTest.testWriteReplaceInheritable =09 BinaryObjectBuilderAdditionalSelfTest.testEnum =09 BinaryObjectBuilderAdditionalSelfTest.testMetadataChanging =09 BinaryObjectBuilderAdditionalSelfTest.testSimpleTypeFieldOverride =09 org.apache.ignite.testsuites.IgniteBinaryObjectsTestSuite: org.apache.ignit= e.internal.binary.noncompact (4) BinaryMarshallerNonCompactSelfTest.testWriteReplaceInheritable =09 BinaryObjectBuilderAdditionalNonCompactSelfTest.testEnum =09 BinaryObjectBuilderAdditionalNonCompactSelfTest.testMetadataChanging = =09 BinaryObjectBuilderAdditionalNonCompactSelfTest.testSimpleTypeFieldOver= ride =20 {noformat} > BinaryUtils#isCustomJavaSerialization fails when only readObject is decla= red in a class > -------------------------------------------------------------------------= -------------- > > Key: IGNITE-8293 > URL: https://issues.apache.org/jira/browse/IGNITE-8293 > Project: Ignite > Issue Type: Bug > Components: binary > Affects Versions: 2.4 > Reporter: MihkelJ > Assignee: MihkelJ > Priority: Minor > Fix For: 2.6 > > > Consider this class: > =C2=A0 > {code:java} > public class Test implements Serializable { > private transient AtomicBoolean dirty =3D new AtomicBoolean(false); > private void readObject(java.io.ObjectInputStream in) throws IOExcept= ion, ClassNotFoundException { > dirty =3D new AtomicBoolean(false); > } > //methods to check and mark class as dirty > }{code} > {{isCustomJavaSerialization}} will get a {{NoSuchMethodException}}=C2=A0w= hen trying to grab the {{writeObject}}=C2=A0method and falsely conclude tha= t Test doesn't use custom serialization. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)