ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Scherbakov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8798) Move transaction recovery logging to INFO level
Date Fri, 15 Jun 2018 14:10:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513861#comment-16513861
] 

Alexei Scherbakov commented on IGNITE-8798:
-------------------------------------------

[~ezagumennov],

I've reviewed your changes and have comments:

1. You should check if info logging is enabled: log.isInfoEnabled()

2. Please switch to info logging in methods:

org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager#finishTxOnRecovery

org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager#commitIfPrepared

org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager#salvageTx(org.apache.ignite.internal.processors.cache.transactions.IgniteInternalTx,
org.apache.ignite.internal.processors.cache.transactions.IgniteInternalTx.FinalizationStatus)

> Move transaction recovery logging to INFO level
> -----------------------------------------------
>
>                 Key: IGNITE-8798
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8798
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexey Goncharuk
>            Assignee: Evgenii Zagumennov
>            Priority: Major
>
> Currently we log transaction recovery state changes to {{DEBUG}}, however, this information
is critically important for production deployment and incident analysis. I suggest to move
corresponding logging ({{GridCacheTxRecoveryFuture}} and surrounding code) to {{INFO}} level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message