ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy Govorukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-8661) WALItreater is not stopped if can not deserialize record
Date Mon, 18 Jun 2018 14:03:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515737#comment-16515737
] 

Dmitriy Govorukhin commented on IGNITE-8661:
--------------------------------------------

[~agoncharuk] I fixed your comments, please take a look again.

> WALItreater is not stopped if can not deserialize record 
> ---------------------------------------------------------
>
>                 Key: IGNITE-8661
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8661
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Dmitriy Govorukhin
>            Assignee: Dmitriy Govorukhin
>            Priority: Major
>             Fix For: 2.6
>
>
> Currently, we have the following code in RecordV1Serializer.readWithCrc:
> {code:java}
> static WALRecord readWithCrc(.....) throws EOFException, IgniteCheckedException {
>   
>     try (FileInput.Crc32CheckingFileInput in = in0.startRead(skipCrc)) {
>       ..... 
>     }
>     catch (EOFException | SegmentEofException | WalSegmentTailReachedException e) {
>         throw e;
>     }
>     catch (Exception e) {
>         throw new IgniteCheckedException("Failed to read WAL record at position: " +
startPos, e);
>     }
> }
> {code}
> So, any runtime error will be remapped to IgniteCheckedException, which will lead to
iterator stop due to the following code:
> AbstractWalRecordsIterator.advanceRecord:
> {code}
>    try {
>          ......
>         }
>         catch (IOException | IgniteCheckedException e) {
>             if (e instanceof WalSegmentTailReachedException)
>                 throw (WalSegmentTailReachedException)e;
>             if (!(e instanceof SegmentEofException))
>                 handleRecordException(e, actualFilePtr);
>             return null;
>         }
> {code}
> Any IgniteCheckedException will be ignored and iterator goes ahead to the next segment.

> I suggest to make the following changes:
> 1) It is unexpected behavior, need to fix it. We should only stop iteration on known
exceptions
> 2) Also, need to provide ability skip records by type or some pointer for the StandaloneWalRecordsIterator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message