From issues-return-63617-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Apr 26 15:45:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A742B180648 for ; Thu, 26 Apr 2018 15:45:03 +0200 (CEST) Received: (qmail 9894 invoked by uid 500); 26 Apr 2018 13:45:02 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 9884 invoked by uid 99); 26 Apr 2018 13:45:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Apr 2018 13:45:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 44D5D1A0508 for ; Thu, 26 Apr 2018 13:45:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5zM_kIo0l1UH for ; Thu, 26 Apr 2018 13:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2C9855F5B2 for ; Thu, 26 Apr 2018 13:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B5C52E0F1B for ; Thu, 26 Apr 2018 13:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 638AE21092 for ; Thu, 26 Apr 2018 13:45:00 +0000 (UTC) Date: Thu, 26 Apr 2018 13:45:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-6528) Warning if no table for BinaryObject MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454223#comment-16454223 ] ASF GitHub Bot commented on IGNITE-6528: ---------------------------------------- GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/3923 IGNITE-6528 Print warnings when actual data type not equal to expected Indexed Type. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6528 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3923.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3923 ---- commit 925ad48468f82053005031f3b5b5eca85323b019 Author: Ilya Kasnacheev Date: 2018-04-26T13:40:27Z IGNITE-6528 Print warnings when actual data type not equal to expected Indexed Type. ---- > Warning if no table for BinaryObject > ------------------------------------ > > Key: IGNITE-6528 > URL: https://issues.apache.org/jira/browse/IGNITE-6528 > Project: Ignite > Issue Type: Improvement > Components: binary, cache, sql > Reporter: Mikhail Cherkasov > Assignee: Ilya Kasnacheev > Priority: Major > > I've seen several times that due wrong cache configuration people can't find > data in cache and blame Ignite that it's buggy and doesn't work. > And it's very difficult to find an error in the code, especially if you don't have reach experience with Ignite. > The problem is that we don't have strong typing when defining QueryEntriy and a user can use an arbitrary string id to > define a type, but he should use the same string id to obtain binary object builder, however, people sometimes confusing this. > So the user can define QueryEntity with value type: queryEntity.setValueType("MyCoolName") and > later put to cache the following binary object: ignite.binary.toBinary(value), but this object won't be indexed, because > ignite.binary.toBinary uses class name as string id while indexing expects to find "MyCoolName" as id. > The example is simple and the error is obvious when you see this two lines close to each other, however, in real life, cache definition and data ingestion are separated by tons of code. > We can save a lot of man-hours for our users if Ignite will print a warning If a cache has a configured QE and user puts BinaryObject with typeName which doesn't correspond to any QE. > The warning should be printed only once, something like: > [WARN] No table is found for %typeName% binary object. -- This message was sent by Atlassian JIRA (v7.6.3#76005)