From issues-return-59137-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Mar 16 04:13:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D6D3B180649 for ; Fri, 16 Mar 2018 04:13:04 +0100 (CET) Received: (qmail 12450 invoked by uid 500); 16 Mar 2018 03:13:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 12440 invoked by uid 99); 16 Mar 2018 03:13:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 03:13:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 69B6DC14F3 for ; Fri, 16 Mar 2018 03:13:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 8FQKqMfS9OOe for ; Fri, 16 Mar 2018 03:13:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8F5D25F1B3 for ; Fri, 16 Mar 2018 03:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CC137E00C6 for ; Fri, 16 Mar 2018 03:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1AB4121278 for ; Fri, 16 Mar 2018 03:13:00 +0000 (UTC) Date: Fri, 16 Mar 2018 03:13:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-7800) Invalid javadoc for IgniteSystemProperties.IGNITE_NO_SHUTDOWN_HOOK MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-7800?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 01414#comment-16401414 ]=20 ASF GitHub Bot commented on IGNITE-7800: ---------------------------------------- GitHub user shroman opened a pull request: https://github.com/apache/ignite/pull/3644 IGNITE-7800: Correction for IgniteSystemProperties.IGNITE_NO_SHUTDOWN= =E2=80=A6 =E2=80=A6_HOOK javadoc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shroman/ignite IGNITE-7800 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3644.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3644 =20 ---- commit e68e0b1ee9ffeb28b0cdd7eb87f1165b2fecdefd Author: shroman Date: 2018-03-16T03:10:32Z IGNITE-7800: Correction for IgniteSystemProperties.IGNITE_NO_SHUTDOWN_H= OOK javadoc. ---- > Invalid javadoc for IgniteSystemProperties.IGNITE_NO_SHUTDOWN_HOOK > ------------------------------------------------------------------ > > Key: IGNITE-7800 > URL: https://issues.apache.org/jira/browse/IGNITE-7800 > Project: Ignite > Issue Type: Bug > Components: 2.3 > Affects Versions: 2.3 > Reporter: Ryszard Trojnacki > Priority: Trivial > Labels: JavaDoc > > JavaDoc for=C2=A0IgniteSystemProperties.IGNITE_NO_SHUTDOWN_HOOK is: > {quote}_If this system property is set to \{@code false} - no shutdown ho= ok will be set._ > {quote} > but this is=C2=A0incorrect. It should be: > {quote}_If this system property is set to {@code *true*} - no shutdown ho= ok will be set._ > {quote} > =C2=A0=C2=A0 > Also in code of=C2=A0IgnitionEx.java comment says it should be true, and = the same is from if expression. > {code:java} > // Do NOT set it up only if IGNITE_NO_SHUTDOWN_HOOK=3DTRUE is provided. i= f (!IgniteSystemProperties.getBoolean(IGNITE_NO_SHUTDOWN_HOOK, false)) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)