From issues-return-59980-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Mar 26 17:26:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 724DF180649 for ; Mon, 26 Mar 2018 17:26:16 +0200 (CEST) Received: (qmail 3270 invoked by uid 500); 26 Mar 2018 15:26:15 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 3257 invoked by uid 99); 26 Mar 2018 15:26:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2018 15:26:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EEDBCC1A5D for ; Mon, 26 Mar 2018 15:26:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lbWTG_dgrzQD for ; Mon, 26 Mar 2018 15:26:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 366A763927 for ; Mon, 26 Mar 2018 13:38:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A10D9E0DEC for ; Mon, 26 Mar 2018 13:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 99494214FD for ; Mon, 26 Mar 2018 13:38:00 +0000 (UTC) Date: Mon, 26 Mar 2018 13:38:00 +0000 (UTC) From: "Maxim Muzafarov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-6842) Stop all nodes after test by default. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-6842?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 13857#comment-16413857 ]=20 Maxim Muzafarov edited comment on IGNITE-6842 at 3/26/18 1:37 PM: ------------------------------------------------------------------ [~dpavlov], I partitially argee with [~NIzhikov] and [~avinogradov] comments because in= [GitHub Pull Request #3542|https://github.com/apache/ignite/pull/3542]=C2= =A0we have changes that not related to this task, which are mentioned p.2. = Nikolay's comment. Basicaly they means that behavior of test framework chan= ged by this PR, because of block of code {code:java} if (startGrid) { IgniteConfiguration cfg =3D optimize(getConfiguration()); G.start(cfg); }{code} moved after beforeTestsStart method execution and at high level means that = we change behavior of it: from: {quote}"In mehtod beforeTestsStarted we can have running grids"=C2=A0 {quote} to: {quote}"In method beforeTestsStarted we can't have running girds" {quote} It's discussable feautre=C2=A0and we can back to discussion of this on dev-= mail list. I've made this chage because of in my opinion "beforeTestsStart"= equals to @BeforeClass annotation from JUnit framework. =C2=A0 Also, I'm really sorry for this missunderstood of basic statements of this = improvement and waisting your time for review actions, I'ts my fault. I'll = prepare [GitHub Pull Request #3699|https://github.com/apache/ignite/pull/36= 99]=C2=A0without this change. was (Author: mmuzaf): [~dpavlov], I partitially argee with [~NIzhikov] and [~avinogradov] comments because in= [GitHub Pull Request #3542|https://github.com/apache/ignite/pull/3542]=C2= =A0we have changes that not related to this task, which are mentioned p.2. = Nikolay's comment. Basicaly they means that behavior of test framework chan= ged by this PR, because of block of code {code:java} if (startGrid) { IgniteConfiguration cfg =3D optimize(getConfiguration()); G.start(cfg); }{code} moved after beforeTestsStart method execution and at high level means that = we change behavior of it: from: {quote}"In mehtod beforeTestsStarted we can have running grids"=C2=A0 {quote} to: {quote}"In method beforeTestsStarted we can't have running girds" {quote} It's discussable feautre=C2=A0and we can back to discussion of this on dev-= mail list. =C2=A0 Also, I'm really sorry for this missunderstood of basic statements of this = improvement and waisting your time for review actions, I'ts my fault. I'll = prepare [GitHub Pull Request #3699|https://github.com/apache/ignite/pull/36= 99]=C2=A0without this change. > Stop all nodes after test by default. > ------------------------------------- > > Key: IGNITE-6842 > URL: https://issues.apache.org/jira/browse/IGNITE-6842 > Project: Ignite > Issue Type: Improvement > Reporter: Alexei Scherbakov > Assignee: Maxim Muzafarov > Priority: Major > Labels: newbie > Fix For: 2.5 > > Attachments: IgniteStopGridsTestSuite.java, StopGridsStateFirstTe= st.java, StopGridsStateSecondTest.java > > > Currently it's required to manually call stopAllGrids() after test comple= tion. > This leads to errors in subsequent tests if someone forgets to call it an= d to additional boilerplate code in tests. > Right choice is to make this default behavior. -- This message was sent by Atlassian JIRA (v7.6.3#76005)