ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-7800) Invalid javadoc for IgniteSystemProperties.IGNITE_NO_SHUTDOWN_HOOK
Date Fri, 16 Mar 2018 03:13:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401414#comment-16401414
] 

ASF GitHub Bot commented on IGNITE-7800:
----------------------------------------

GitHub user shroman opened a pull request:

    https://github.com/apache/ignite/pull/3644

    IGNITE-7800: Correction for IgniteSystemProperties.IGNITE_NO_SHUTDOWN…

    …_HOOK javadoc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shroman/ignite IGNITE-7800

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3644
    
----
commit e68e0b1ee9ffeb28b0cdd7eb87f1165b2fecdefd
Author: shroman <rshtykh@...>
Date:   2018-03-16T03:10:32Z

    IGNITE-7800: Correction for IgniteSystemProperties.IGNITE_NO_SHUTDOWN_HOOK javadoc.

----


> Invalid javadoc for IgniteSystemProperties.IGNITE_NO_SHUTDOWN_HOOK
> ------------------------------------------------------------------
>
>                 Key: IGNITE-7800
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7800
>             Project: Ignite
>          Issue Type: Bug
>          Components: 2.3
>    Affects Versions: 2.3
>            Reporter: Ryszard Trojnacki
>            Priority: Trivial
>              Labels: JavaDoc
>
> JavaDoc for IgniteSystemProperties.IGNITE_NO_SHUTDOWN_HOOK is:
> {quote}_If this system property is set to \{@code false} - no shutdown hook will be set._
> {quote}
> but this is incorrect. It should be:
> {quote}_If this system property is set to {@code *true*} - no shutdown hook will be set._
> {quote}
>   
> Also in code of IgnitionEx.java comment says it should be true, and the same is from
if expression.
> {code:java}
> // Do NOT set it up only if IGNITE_NO_SHUTDOWN_HOOK=TRUE is provided. if (!IgniteSystemProperties.getBoolean(IGNITE_NO_SHUTDOWN_HOOK,
false)) {
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message