ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Muzafarov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-6842) Stop all nodes after test by default.
Date Mon, 26 Mar 2018 13:38:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413857#comment-16413857
] 

Maxim Muzafarov edited comment on IGNITE-6842 at 3/26/18 1:37 PM:
------------------------------------------------------------------

[~dpavlov],

I partitially argee with [~NIzhikov] and [~avinogradov] comments because in [GitHub Pull Request
#3542|https://github.com/apache/ignite/pull/3542] we have changes that not related to this
task, which are mentioned p.2. Nikolay's comment. Basicaly they means that behavior of test
framework changed by this PR, because of block of code
{code:java}
if (startGrid) {
 IgniteConfiguration cfg = optimize(getConfiguration());

 G.start(cfg);
}{code}
moved after beforeTestsStart method execution and at high level means that we change behavior
of it:

from:
{quote}"In mehtod beforeTestsStarted we can have running grids" 
{quote}
to:
{quote}"In method beforeTestsStarted we can't have running girds"
{quote}
It's discussable feautre and we can back to discussion of this on dev-mail list. I've made
this chage because of in my opinion "beforeTestsStart" equals to @BeforeClass annotation from
JUnit framework.

 

Also, I'm really sorry for this missunderstood of basic statements of this improvement and
waisting your time for review actions, I'ts my fault. I'll prepare [GitHub Pull Request #3699|https://github.com/apache/ignite/pull/3699] without
this change.


was (Author: mmuzaf):
[~dpavlov],

I partitially argee with [~NIzhikov] and [~avinogradov] comments because in [GitHub Pull Request
#3542|https://github.com/apache/ignite/pull/3542] we have changes that not related to this
task, which are mentioned p.2. Nikolay's comment. Basicaly they means that behavior of test
framework changed by this PR, because of block of code
{code:java}
if (startGrid) {
 IgniteConfiguration cfg = optimize(getConfiguration());

 G.start(cfg);
}{code}
moved after beforeTestsStart method execution and at high level means that we change behavior
of it:

from:
{quote}"In mehtod beforeTestsStarted we can have running grids" 
{quote}
to:
{quote}"In method beforeTestsStarted we can't have running girds"
{quote}
It's discussable feautre and we can back to discussion of this on dev-mail list.

 

Also, I'm really sorry for this missunderstood of basic statements of this improvement and
waisting your time for review actions, I'ts my fault. I'll prepare [GitHub Pull Request #3699|https://github.com/apache/ignite/pull/3699] without
this change.

> Stop all nodes after test by default.
> -------------------------------------
>
>                 Key: IGNITE-6842
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6842
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexei Scherbakov
>            Assignee: Maxim Muzafarov
>            Priority: Major
>              Labels: newbie
>             Fix For: 2.5
>
>         Attachments: IgniteStopGridsTestSuite.java, StopGridsStateFirstTest.java, StopGridsStateSecondTest.java
>
>
> Currently it's required to manually call stopAllGrids() after test completion.
> This leads to errors in subsequent tests if someone forgets to call it and to additional
boilerplate code in tests.
> Right choice is to make this default behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message