ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-7530) .NET: Poor performance & excessive memory usage in GetAll and query cursors in binary mode
Date Thu, 25 Jan 2018 14:13:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339260#comment-16339260
] 

ASF GitHub Bot commented on IGNITE-7530:
----------------------------------------

GitHub user ptupitsyn opened a pull request:

    https://github.com/apache/ignite/pull/3436

    IGNITE-7530 .NET: Fix memory usage and performance for GetAll and query cursors in binary
mode

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptupitsyn/ignite ignite-7530

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3436
    
----
commit 219bbf1fc6c2808a16f881a7f2e41adf51fd2916
Author: apopov <tank2.alex@...>
Date:   2018-01-25T09:58:16Z

    GetAllBinaryBenchmark issue

commit bb60c552952cc6c14204fc1def9222664cb6bfd3
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-25T11:34:11Z

    Fix binary object excessive memory copy issue.

commit 0ea15d3e45c915b40aa25c564468095cbce307ee
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-25T12:27:47Z

    Merge branch 'master' into get-all-binary-issue

commit cc1943e7dc81d6ca1898acbea0d8d0fa0e891a23
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-25T12:49:53Z

    IGNITE-7530 .NET: Poor performance & excessive memory usage in GetAll and query cursors
in binary mode

commit 3fd6e47894d4996a3b65b63bd112c65de0082f1f
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-25T13:24:16Z

    Add CanGetArray guard

commit 725757e0f9f482a2f55bd6dd5248bf4d8b2f71a4
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-25T13:31:28Z

    Fixing tests

commit db4f89afaa4e905ba08ef8269cca512580e8b9a3
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-25T13:43:09Z

    цшз

commit e83c1465cd659542c04f5f305b7fc2daad6f2338
Author: Pavel Tupitsyn <ptupitsyn@...>
Date:   2018-01-25T13:45:26Z

    Code cleanup

----


> .NET: Poor performance & excessive memory usage in GetAll and query cursors in binary
mode
> ------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-7530
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7530
>             Project: Ignite
>          Issue Type: Bug
>          Components: platforms
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Major
>              Labels: .NET
>             Fix For: 2.4
>
>
> {{GetAll}} and query cursors do not use {{BinaryReader.DetachNext}}. So in binary mode
for each binary object in a stream we copy entire stream content, see {{BinaryReader.ReadAsBinary}},
which calls {{Stream.GetArray()}}, which causes copying in {{PlatformMemoryStream}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message