Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5FC3A200D5C for ; Fri, 15 Dec 2017 09:02:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5E3BB160C14; Fri, 15 Dec 2017 08:02:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A2BF9160C06 for ; Fri, 15 Dec 2017 09:02:03 +0100 (CET) Received: (qmail 49649 invoked by uid 500); 15 Dec 2017 08:02:02 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 49639 invoked by uid 99); 15 Dec 2017 08:02:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Dec 2017 08:02:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 231C5180990 for ; Fri, 15 Dec 2017 08:02:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Rc7CPR9sny3m for ; Fri, 15 Dec 2017 08:02:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 095B05F39D for ; Fri, 15 Dec 2017 08:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86FF8E0F4F for ; Fri, 15 Dec 2017 08:02:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 49C0327405 for ; Fri, 15 Dec 2017 08:02:00 +0000 (UTC) Date: Fri, 15 Dec 2017 08:02:00 +0000 (UTC) From: "Roman Kondakov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-7039) SQL: local query should pin affected partitions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 15 Dec 2017 08:02:04 -0000 [ https://issues.apache.org/jira/browse/IGNITE-7039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292167#comment-16292167 ] Roman Kondakov commented on IGNITE-7039: ---------------------------------------- [~vozerov], please review. 1) In {{IgniteH2Indexing.queryLocalSqlFields}} I implemented an eager partitions reservation on {{IgniteCache.query()}} call. I also implemented a test {{IgniteCacheLocalQueryReservationsTest}} for checking a partitions reservation status on each stage: * Before {{IgniteCache.query()}}. * After {{IgniteCache.query()}}. * After {{QueryCursor.iterator()}}. * After {{Iterator.next()}}. * After {{QueryCursor.close()}}. 2. I implemented another method for a gathering all caches ids used in a query based on {{GridSqlQueryParser}}. I also added a cache map for the parsed queries. > SQL: local query should pin affected partitions > ----------------------------------------------- > > Key: IGNITE-7039 > URL: https://issues.apache.org/jira/browse/IGNITE-7039 > Project: Ignite > Issue Type: Bug > Components: sql > Reporter: Vladimir Ozerov > Assignee: Roman Kondakov > Fix For: 2.4 > > > When distributed query is executed, we pin cache partitions for particular topology version on map nodes [1]. However, it seems that we do no do that for local queries. This is a bug because partition with required data could be evicted from local node at any time, leading to incorrect results. > [1] https://github.com/apache/ignite/blob/ignite-2.3/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java#L288 -- This message was sent by Atlassian JIRA (v6.4.14#64029)