ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Gura (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion
Date Tue, 12 Dec 2017 10:17:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287397#comment-16287397
] 

Andrey Gura edited comment on IGNITE-602 at 12/12/17 10:16 AM:
---------------------------------------------------------------

[~SomeFire] We discussed earlier (https://issues.apache.org/jira/browse/IGNITE-602?focusedCommentId=16184176&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16184176)
that it's very strange to change core classes when fix should affect only utility classes.
Why {{@GridToStringExclude}} annotation in {{GridNioServer}} leads to failures?


was (Author: agura):
[~SomeFire] We discussed early (https://issues.apache.org/jira/browse/IGNITE-602?focusedCommentId=16184176&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16184176)
that it's very strange to change core classes when fix should affect only utility classes.
Why {{@GridToStringExclude}} annotation in {{GridNioServer}} leads to failures?

> [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion
> --------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-602
>                 URL: https://issues.apache.org/jira/browse/IGNITE-602
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>            Reporter: Artem Shutak
>            Assignee: Ryabov Dmitrii
>              Labels: MakeTeamcityGreenAgain, Muted_test
>             Fix For: 2.4
>
>
> See test org.gridgain.grid.util.tostring.GridToStringBuilderSelfTest#_testToStringCheckAdvancedRecursionPrevention
and related TODO in same source file.
> Also take a look at http://stackoverflow.com/questions/11300203/most-efficient-way-to-prevent-an-infinite-recursion-in-tostring
> Test should be unmuted on TC after fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message