Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Tue, 14 Nov 2017 11:17:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.13118213.1510657660000.231697.1510658220828@Atlassian.JIRA>
In-Reply-To: <JIRA.13118213.1510657660000@Atlassian.JIRA>
References: <JIRA.13118213.1510657660000@Atlassian.JIRA> <JIRA.13118213.1510657660593@jira-lw-us.apache.org>
Subject: [jira] [Commented] (IGNITE-6901)
 IgniteH2Indexing#rebuildIndexesFromHash should pass old value to indexing
 engine
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 14 Nov 2017 11:17:08 -0000


    [ https://issues.apache.org/jira/browse/IGNITE-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251251#comment-16251251 ] 

ASF GitHub Bot commented on IGNITE-6901:
----------------------------------------

GitHub user devozerov opened a pull request:

    https://github.com/apache/ignite/pull/3027

    IGNITE-6901

    
You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-6901

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3027
    
----
commit 1c4a41e54a654023f3327d72ae7e480825c93737
Author: devozerov <vozerov@gridgain.com>
Date:   2017-11-14T11:16:19Z

    Fix.

----


> IgniteH2Indexing#rebuildIndexesFromHash should pass old value to indexing engine
> --------------------------------------------------------------------------------
>
>                 Key: IGNITE-6901
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6901
>             Project: Ignite
>          Issue Type: Task
>      Security Level: Public(Viewable by anyone) 
>          Components: cache, persistence, sql
>            Reporter: Vladimir Ozerov
>            Assignee: Alexey Goncharuk
>             Fix For: 2.4
>
>
> When index rebuild is triggered, index is updated from the method {{IgniteCacheOffheapManagerImpl.CacheDataStoreImpl.updateIndexes}}. Notice how we always pass {{null}} as previous row value. It breaks recent optimization which use previous value to avoid old row materialization IGNITE-6701, so assertion like this is observed:
> {code}
> java.lang.AssertionError: Replaced: true
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.query.h2.opt.GridH2Table.update(GridH2Table.java:451)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.store(IgniteH2Indexing.java:581)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.query.GridQueryProcessor.store(GridQueryProcessor.java:1748)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager.store(GridCacheQueryManager.java:406)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl$CacheDataStoreImpl.updateIndexes(IgniteCacheOffheapManagerImpl.java:1375)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.cache.persistence.GridCacheOffheapManager$GridCacheDataStore.updateIndexes(GridCacheOffheapManager.java:1242)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.updateIndexes(IgniteCacheOffheapManagerImpl.java:364)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.cache.GridCacheMapEntry.ensureIndexed(GridCacheMapEntry.java:3149)
> [00:30:30][org.gridgain:gridgain-ultimate] 	at org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.rebuildIndexesFromHash(IgniteH2Indexing.java:2030)
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)