Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9A541200D5C for ; Thu, 30 Nov 2017 13:22:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 98F14160BEA; Thu, 30 Nov 2017 12:22:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E6E40160BF4 for ; Thu, 30 Nov 2017 13:22:03 +0100 (CET) Received: (qmail 67541 invoked by uid 500); 30 Nov 2017 12:22:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 67532 invoked by uid 99); 30 Nov 2017 12:22:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2017 12:22:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 977C9C3F1E for ; Thu, 30 Nov 2017 12:22:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.011 X-Spam-Level: X-Spam-Status: No, score=-99.011 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KB_WAM_FROM_NAME_SINGLEWORD=0.2, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tzU_FEYanJzA for ; Thu, 30 Nov 2017 12:22:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4632B5F566 for ; Thu, 30 Nov 2017 12:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6990AE0044 for ; Thu, 30 Nov 2017 12:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 294E32105A for ; Thu, 30 Nov 2017 12:22:00 +0000 (UTC) Date: Thu, 30 Nov 2017 12:22:00 +0000 (UTC) From: "Alexey Kuznetsov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-6846) Add metrics for entry processor invocations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 30 Nov 2017 12:22:04 -0000 [ https://issues.apache.org/jira/browse/IGNITE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272393#comment-16272393 ] Alexey Kuznetsov edited comment on IGNITE-6846 at 11/30/17 12:21 PM: --------------------------------------------------------------------- [~vkulichenko] Ok, Im going to rework API. And make 'invoke' metrics be calculated the similar way as corresponding regular cache operations. There will be problems with implementing "getAverageEntryProcessorReadOnlyInvocationTime();" metric, because we don't know whether invoke is read-only or not on initiating node(node, initiated invoke operation, and waiting for invoke response from cluster) was (Author: alexey kuznetsov): [~vkulichenko] Ok, Im going to rework API. And make 'invoke' metrics be calculated the similar way as corresponding regular cache operations. There will be problems with implementing "getAverageEntryProcessorReadOnlyInvocationTime();" metric, because we don't know whether invoke is read-only or not on initiating node(node, initiated invoke operation, and waiting for invoke response from cluster) But again. Currently for regular remove operation(in case if cache is empty): * In TRANSACTIONAL cache 'remove' metric is incremented on nodes * But, in ATOMIC cache its not incremented. Seems its a bug? > Add metrics for entry processor invocations > ------------------------------------------- > > Key: IGNITE-6846 > URL: https://issues.apache.org/jira/browse/IGNITE-6846 > Project: Ignite > Issue Type: Improvement > Components: cache > Affects Versions: 2.3 > Reporter: Valentin Kulichenko > Assignee: Alexey Kuznetsov > Priority: Critical > Labels: iep-6 > Fix For: 2.4 > > > {{CacheMetrics}} object has multiple metrics for various cache operations like {{get}}, {{put}} and {{remove}}, but nothing for {{invoke}}/{{EntryProcessor}}. It makes sense to add such metrics, for example: > * Total number of `invoke` operations executed. > * Number of `invoke` operations that included updates. > * Number of read-only `invoke` operations. > * Min/max/avg execution time. > * ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)