Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Fri, 24 Nov 2017 14:45:00 +0000 (UTC)
From: "Alexey Kuznetsov (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.13117085.1510172880000.315611.1511534700171@Atlassian.JIRA>
In-Reply-To: <JIRA.13117085.1510172880000@Atlassian.JIRA>
References: <JIRA.13117085.1510172880000@Atlassian.JIRA> <JIRA.13117085.1510172880063@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (IGNITE-6846) Add metrics for entry
 processor invocations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 24 Nov 2017 14:45:04 -0000


    [ https://issues.apache.org/jira/browse/IGNITE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264488#comment-16264488 ] 

Alexey Kuznetsov edited comment on IGNITE-6846 at 11/24/17 2:44 PM:
--------------------------------------------------------------------

When entry is updated, both 'invoke update' and get\put\remove metrics updated.
When entry processor is invoked, but cache entry isn't affected, then invoke metric isn't incremented.
'invoke update' metrics incremented only when cache entry value is changed(or removed) by entry processor(not just when entry processor is invoked).
If entry processor process(...) is called once, and multiple entries(perhaps on different nodes) are affected, then local invoke metric is incremented only once, cluster global metric is incremented once.
Read-only 'invoke' operation is processor invocation without calling entry.setValue(...) (even entry.getValue() can not be called), processor still can return nin-null value.


was (Author: alexey kuznetsov):
When entry is updated, both 'invoke update' and get\put\remove metrics updated.
When entry processor is invoked, but cache entry isn't affected, then invoke metric isn't incremented.
'invoke update' metrics incremented only when cache entry value is changed(or removed) by entry processor(not just when entry processor is invoked).
If entry processor process(...) is called once, and multiple entries(perhaps on different nodes) are affected, then local invoke metric is incremented only once, cluster global metric is incremented once.
Read-only 'invoke' operation is processor invocation without calling entry.setValue(...), processor still can return nin-null value.

> Add metrics for entry processor invocations
> -------------------------------------------
>
>                 Key: IGNITE-6846
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6846
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>    Affects Versions: 2.3
>            Reporter: Valentin Kulichenko
>            Assignee: Alexey Kuznetsov
>            Priority: Critical
>              Labels: iep-6
>             Fix For: 2.4
>
>
> {{CacheMetrics}} object has multiple metrics for various cache operations like {{get}}, {{put}} and {{remove}}, but nothing for {{invoke}}/{{EntryProcessor}}. It makes sense to add such metrics, for example:
> * Total number of `invoke` operations executed.
> * Number of `invoke` operations that included updates.
> * Number of read-only `invoke` operations.
> * Min/max/avg execution time.
> * ...


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)