Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Tue, 28 Nov 2017 12:03:00 +0000 (UTC)
From: "Andrey Kuznetsov (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.13097543.1503655881000.333928.1511870580080@Atlassian.JIRA>
In-Reply-To: <JIRA.13097543.1503655881000@Atlassian.JIRA>
References: <JIRA.13097543.1503655881000@Atlassian.JIRA> <JIRA.13097543.1503655881985@jira-lw-us.apache.org>
Subject: [jira] [Updated] (IGNITE-6186) Remove redundant parameter of
 GridFutureAdapter::unregisterWaiter()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 28 Nov 2017 12:03:04 -0000


     [ https://issues.apache.org/jira/browse/IGNITE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Kuznetsov updated IGNITE-6186:
-------------------------------------
    Description: 
The method is not thread-safe unless actual parameter is currentThread.

Let future state is a list of listeners and two concurrent threads are removing two adjacent non-root listener nodes from list simultaneously by calling {{unregisterWaiter()}}. Then data race is possible: one of these listeners can survive its removal. If the listener is a thread waiting for completion in {{get0()}} then this race leads at worst case to 1 extra call to {{LockSupport.park()}}, and it's negligible. Otherwise we deal with an arbitrary listener, and its {{apply()}} will be called twice.

  was:The method is not thread-safe unless actual parameter is currentThread.


> Remove redundant parameter of GridFutureAdapter::unregisterWaiter()
> -------------------------------------------------------------------
>
>                 Key: IGNITE-6186
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6186
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.1
>            Reporter: Andrey Kuznetsov
>            Assignee: Andrey Kuznetsov
>            Priority: Minor
>
> The method is not thread-safe unless actual parameter is currentThread.
> Let future state is a list of listeners and two concurrent threads are removing two adjacent non-root listener nodes from list simultaneously by calling {{unregisterWaiter()}}. Then data race is possible: one of these listeners can survive its removal. If the listener is a thread waiting for completion in {{get0()}} then this race leads at worst case to 1 extra call to {{LockSupport.park()}}, and it's negligible. Otherwise we deal with an arbitrary listener, and its {{apply()}} will be called twice.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)