Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Wed, 8 Nov 2017 10:52:00 +0000 (UTC)
From: "Oleg Ignatenko (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.13071963.1494848793000.180250.1510138320209@Atlassian.JIRA>
In-Reply-To: <JIRA.13071963.1494848793000@Atlassian.JIRA>
References: <JIRA.13071963.1494848793000@Atlassian.JIRA> <JIRA.13071963.1494848793439@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (IGNITE-5218) Decision trees
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 08 Nov 2017 10:52:05 -0000


    [ https://issues.apache.org/jira/browse/IGNITE-5218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237974#comment-16237974 ] 

Oleg Ignatenko edited comment on IGNITE-5218 at 11/8/17 10:51 AM:
------------------------------------------------------------------

Example provided for decision trees ([MNISTExample|https://github.com/gridgain/apache-ignite/blob/ignite-5218/examples/src/main/ml/org/apache/ignite/examples/ml/math/trees/MNISTExample.java]) looks sufficiently documented and runs fine on my machine.

Unit tests run successfully on my machine ([DecisionTreesTestSuite|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/DecisionTreesTestSuite.java]), as well as "internal" benchmark [ColumnDecisionTreeTrainerBenchmark|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/performance/ColumnDecisionTreeTrainerBenchmark.java]. Worth noting that yesterday Yury did a [trial run on TC|https://ci.ignite.apache.org/viewLog.html?buildId=927458&buildTypeId=Ignite20Tests_IgniteMl&tab=buildResultsDiv] for this pull request and it came out all green.

Code formatting looks right in both main and test parts.

Code inspections results are okay in both main and test parts.

I also re-run this PR on TeamCity in order to make sure that changes made during review didn't introduce failures. [The link of TC results|https://ci.ignite.apache.org/viewLog.html?buildId=933522&] was added to this ticket so that it's easier to check for the committer.


was (Author: oignatenko):
Example provided for decision trees ([MNISTExample|https://github.com/gridgain/apache-ignite/blob/ignite-5218/examples/src/main/ml/org/apache/ignite/examples/ml/math/trees/MNISTExample.java]) looks sufficiently documented and runs fine on my machine.

Unit tests run successfully on my machine ([DecisionTreesTestSuite|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/DecisionTreesTestSuite.java]), as well as "internal" benchmark [ColumnDecisionTreeTrainerBenchmark|https://github.com/gridgain/apache-ignite/blob/ignite-5218/modules/ml/src/test/java/org/apache/ignite/ml/trees/performance/ColumnDecisionTreeTrainerBenchmark.java]. Worth noting that yesterday Yury did a [trial run on TC|https://ci.ignite.apache.org/viewLog.html?buildId=927458&buildTypeId=Ignite20Tests_IgniteMl&tab=buildResultsDiv] for this pull request and it came out all green.

Code formatting looks right in both main and test parts.

Code inspections results are okay in both main and test parts.

(!) [~amalykh] - prior to passing this PR to committer for merge please re-run PR on TeamCity in order to make sure that changes made during review didn't introduce failures. Add the link of TC results to this ticket so that it's easier to check for the committer.

> Decision trees
> --------------
>
>                 Key: IGNITE-5218
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5218
>             Project: Ignite
>          Issue Type: New Feature
>          Components: ml
>            Reporter: Yury Babak
>            Assignee: Artem Malykh
>
> We want to implement Decision trees for Ignite ML because it's really common one for ML.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)