ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5755) Wrong msg: calculation of memory policy size
Date Thu, 16 Nov 2017 12:16:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255210#comment-16255210
] 

ASF GitHub Bot commented on IGNITE-5755:
----------------------------------------

GitHub user sergvolkov opened a pull request:

    https://github.com/apache/ignite/pull/3044

    IGNITE-5755 change calculation of memory policy size

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sergvolkov/ignite ignite-2.1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3044
    
----
commit e593c768aa7dcbfed30f2592e5ea1e1ad35ded77
Author: SA.Volkov <sa.volkov@jet.msk.su>
Date:   2017-11-16T12:10:22Z

    IGNITE-5755 change calculation of memory policy size

----


> Wrong msg: calculation of memory policy size
> --------------------------------------------
>
>                 Key: IGNITE-5755
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5755
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 2.1
>            Reporter: Alexander Belyak
>            Assignee: Sergey Volkov
>            Priority: Trivial
>
> In PageMemoryNoStoreImpl:
> {noformat}
>             throw new IgniteOutOfMemoryException("Not enough memory allocated " +
>                 "(consider increasing memory policy size or enabling evictions) " +
>                 "[policyName=" + memoryPolicyCfg.getName() +
>                 ", size=" + U.readableSize(memoryPolicyCfg.getMaxSize(), true) + "]"
> {noformat}
> wrong usage of U.readableSize - we should use non "Si" (1024 instead of 1000) multiplier.
Right code is:
> {noformat}
>             throw new IgniteOutOfMemoryException("Not enough memory allocated " +
>                 "(consider increasing memory policy size or enabling evictions) " +
>                 "[policyName=" + memoryPolicyCfg.getName() +
>                 ", size=" + U.readableSize(memoryPolicyCfg.getMaxSize(), false) + "]"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message