ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy Govorukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-6307) If getAll() fails with NPE, onHeap entry is not removed, for local cache
Date Wed, 13 Sep 2017 09:46:03 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164397#comment-16164397
] 

Dmitriy Govorukhin commented on IGNITE-6307:
--------------------------------------------

Hi [~NIzhikov], your changes looks good for me, but i doubt the performance. I think we must
check performance benchmark before merge into master.

> If getAll() fails with NPE, onHeap entry is not removed, for local cache
> ------------------------------------------------------------------------
>
>                 Key: IGNITE-6307
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6307
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 2.0
>            Reporter: Dmitriy Govorukhin
>            Assignee: Nikolay Izhikov
>              Labels: MakeTeamcityGreenAgain
>             Fix For: 2.3
>
>
> GridCacheLocalFullApiSelfTest.testGetAllWithNulls
> {code}
>     final Set<String> c = new HashSet<>();
>         c.add("key1");
>         c.add(null);
>         GridTestUtils.assertThrows(log, new Callable<Void>() {
>             @Override public Void call() throws Exception {
>                 cache.getAll(c);
>                 return null;
>             }
>         }, NullPointerException.class, null);
> {code}
> After getAll, entry with "key1" will be in heap map, it is dependent of order in collection
for getAll();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message