ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Ozerov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-6301) CacheConfiguration.indexedTypes never initialized and can be removed
Date Mon, 11 Sep 2017 09:10:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160955#comment-16160955
] 

Vladimir Ozerov commented on IGNITE-6301:
-----------------------------------------

You rely on the fact that {{IgniteConfiguration}} is serialized with JDK, which might not
be the case. E.g. some user may serialize it with some other serialization tool with other
guarantees. Provided that this fix doesn't add any value to the product, I would rather close
it as "Won't Fix" to avoid any risks for existing users.

> CacheConfiguration.indexedTypes never initialized and can be removed
> --------------------------------------------------------------------
>
>                 Key: IGNITE-6301
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6301
>             Project: Ignite
>          Issue Type: Bug
>          Components: sql
>    Affects Versions: 2.1
>            Reporter: Nikolay Izhikov
>            Assignee: Nikolay Izhikov
>            Priority: Trivial
>
> CacheConfiguration#indexedTypes never initialized and can be removed
> {code:java}
> public class CacheConfiguration<K, V> extends MutableConfiguration<K, V>
{
> //...
>     /** */
>     private transient Class<?>[] indexedTypes;
> //....
>     public CacheConfiguration<K, V> setIndexedTypes(Class<?>... indexedTypes)
{
>         if (F.isEmpty(indexedTypes))
>             return this;
>         int len = indexedTypes.length;
>         if (len == 0)
>             return this;
>         A.ensure((len & 1) == 0,
>             "Number of indexed types is expected to be even. Refer to method javadoc
for details.");
>         if (this.indexedTypes != null)
>             throw new CacheException("Indexed types can be set only once.");
>         Class<?>[] newIndexedTypes = new Class<?>[len];
> // other method body fill qryEntities list.
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message