ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kousuke Saruta (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-6002) Make log message more pretty when instance name is null
Date Wed, 13 Sep 2017 11:37:02 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164521#comment-16164521
] 

Kousuke Saruta edited comment on IGNITE-6002 at 9/13/17 11:36 AM:
------------------------------------------------------------------

[~avinogradov] Thanks for your reply!

{quote}
It looks like you changed name=null with empty space.
Could you please explain reason to hide param in case it's value is null?
{quote}
I think, it's not useful information and little bit ugly.
There are already lots of code like this change in IgniteKernel.java. Following example is
one of them.

{code}
log = (GridLoggerProxy)cfg.getGridLogger().getLogger(
    getClass().getName() + (igniteInstanceName != null ? '%' + igniteInstanceName : ""));
{code}

{quote}
Also, next time, please, assign issue to yourself before asking review.
{quote}

I'd like to do that but I didn't edit Assignee field.



was (Author: sarutak):
[~avinogradov] Thanks for your reply!

{quote}
It looks like you changed name=null with empty space.
Could you please explain reason to hide param in case it's value is null?
{quote}
I think, it's not useful information and little bit ugly.
There are already lots of code like this change in IgniteKernel.java. Following example is
one of them.

{code}
log = (GridLoggerProxy)cfg.getGridLogger().getLogger(
    getClass().getName() + (igniteInstanceName != null ? '%' + igniteInstanceName : ""));
{code}

{code}
Also, next time, please, assign issue to yourself before asking review.
{code}

I'd like to do that but I didn't edit Assignee field.


> Make log message more pretty when instance name is null
> -------------------------------------------------------
>
>                 Key: IGNITE-6002
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6002
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 2.2
>            Reporter: Kousuke Saruta
>            Priority: Minor
>
> When instance name is null, log message containing "null" is shown like as follows.
> {code}
> [09-08-2017 14:49:38][INFO ][grid-timeout-worker-#15%null%][IgniteKernal]
> Metrics for local node (to disable set 'metricsLogFrequency' to 0)
>     ^-- Node [id=de0743ec, name=null, uptime=00:01:00:007]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message