Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CD6DF200CE0 for ; Fri, 25 Aug 2017 14:56:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C9F6316C97E; Fri, 25 Aug 2017 12:56:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 19A8616C979 for ; Fri, 25 Aug 2017 14:56:05 +0200 (CEST) Received: (qmail 25039 invoked by uid 500); 25 Aug 2017 12:56:03 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 25030 invoked by uid 99); 25 Aug 2017 12:56:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Aug 2017 12:56:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3296AC8745 for ; Fri, 25 Aug 2017 12:56:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5oZFcBViL_MG for ; Fri, 25 Aug 2017 12:56:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C654C60D9B for ; Fri, 25 Aug 2017 12:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E570EE0DCA for ; Fri, 25 Aug 2017 12:56:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3CA1725385 for ; Fri, 25 Aug 2017 12:56:00 +0000 (UTC) Date: Fri, 25 Aug 2017 12:56:00 +0000 (UTC) From: "Taras Ledkov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-6125) Improve robustness for JDBC driver metadata queries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 25 Aug 2017 12:56:07 -0000 [ https://issues.apache.org/jira/browse/IGNITE-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141576#comment-16141576 ] Taras Ledkov edited comment on IGNITE-6125 at 8/25/17 12:55 PM: ---------------------------------------------------------------- The patch is OK with me. We have to review {{jdbc2.JdbcDatabaseMetadata}} and implement some methods correctly. - getTypeInfo() now returns empty results set. - pay attention to the all methods that return empty result set. Now the result's metadata isn't available. Please file separate tickets for these tasks. was (Author: tledkov-gridgain): The patch is OK with me. We have to review {{jdbc2.JdbcDatabaseMetadata}} and implement some methods correctly. - getTypeInfo() now returns empty results set. - pay attention to the all methods that return empty result set. Now the result's metadata isn't available. > Improve robustness for JDBC driver metadata queries > --------------------------------------------------- > > Key: IGNITE-6125 > URL: https://issues.apache.org/jira/browse/IGNITE-6125 > Project: Ignite > Issue Type: Task > Components: clients, jdbc > Affects Versions: 2.1 > Reporter: Ilya Kasnacheev > Assignee: Ilya Kasnacheev > Fix For: 2.2 > > > org.apache.ignite.internal.jdbc2.JdbcDatabaseMetadata is in worrysome state: > - Makes frivolous use of toUpperCase() to address former. > - getPrimaryKeys() never returns anything because of defective use of toUpperCase(). > - No tests on indexes, primary keys, schemas or parameters metadata retrieval. > - Ignores "catalog" parameter instead of checking if it matches empty catalog. > - See also IGNITE-6138, IGNITE-6139 > That should be fixes without compromising backwards compatibility too much. Tests may be borrowed from thin client implementation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)